bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Address review comments

Browse source
This commit is contained in:
Aaron Hill 2021-08-21 14:11:36 -05:00
parent 17aef21b30
commit 62aea8c913
No known key found for this signature in database
GPG key ID: B4087E510E98B164
4 changed files with 578 additions and 854 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_passes/src/check_attr.rs
View file

@ -130,6 +130,12 @@ impl CheckAttrVisitor<'tcx> {
sym::ignore | sym::should_panic | sym::proc_macro_derive => {
self.check_generic_attr(hir_id, attr, target, &[Target::Fn])
}
sym::automatically_derived => {
self.check_generic_attr(hir_id, attr, target, &[Target::Impl])
}
sym::no_implicit_prelude => {
self.check_generic_attr(hir_id, attr, target, &[Target::Mod])
}
_ => {}
}
@ -290,7 +296,6 @@ impl CheckAttrVisitor<'tcx> {
b.push_str(&(allowed_target.to_string() + "s"));
b
});
//let supported_names = allowed_targets.iter().fold(String::new(), |msg, t| msg + ", " + &t.to_string());
self.tcx.struct_span_lint_hir(UNUSED_ATTRIBUTES, hir_id, attr.span, |lint| {
lint.build(&format!("`#[{name}]` only has an effect on {}", supported_names))
.emit();