bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

When encountering <&T as Clone>::clone(x) because T: Clone, suggest #[derive(Clone)]

Browse source 
CC #40699.
This commit is contained in:
Esteban Küber 2024-02-22 18:01:12 +00:00
parent 2dc0170233
commit 6017de46f7
6 changed files with 80 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_lint/src/noop_method_call.rs
View file

@ -121,10 +121,20 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall {
let orig_ty = expr_ty.peel_refs();
if receiver_ty == expr_ty {
let suggest_derive = match orig_ty.kind() {
ty::Adt(def, _) => Some(cx.tcx.def_span(def.did()).shrink_to_lo()),
_ => None,
};
cx.emit_span_lint(
NOOP_METHOD_CALL,
span,
NoopMethodCallDiag { method: call.ident.name, orig_ty, trait_, label: span },
NoopMethodCallDiag {
method: call.ident.name,
orig_ty,
trait_,
label: span,
suggest_derive,
},
);
} else {
match name {