don't infer region paramaterization for ids in a bound context
This commit is contained in:
parent
89222646f4
commit
5eea7d6e61
2 changed files with 43 additions and 3 deletions
|
@ -518,6 +518,21 @@ impl determine_rp_ctxt {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// For named types like Foo, if there is no explicit region
|
||||||
|
// parameter, then we will add the anonymous region, so there is
|
||||||
|
// a dependency if the anonymous region implies rp.
|
||||||
|
//
|
||||||
|
// If the region is explicitly specified, then we follows the
|
||||||
|
// normal rules.
|
||||||
|
fn opt_region_is_relevant(opt_r: option<@ast::region>) -> bool {
|
||||||
|
debug!("opt_region_is_relevant: %? (anon_implies_rp=%b)",
|
||||||
|
opt_r, self.anon_implies_rp);
|
||||||
|
match opt_r {
|
||||||
|
none => self.anon_implies_rp,
|
||||||
|
some(r) => self.region_is_relevant(r)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn with(item_id: ast::node_id,
|
fn with(item_id: ast::node_id,
|
||||||
anon_implies_rp: bool,
|
anon_implies_rp: bool,
|
||||||
f: fn()) {
|
f: fn()) {
|
||||||
|
@ -613,11 +628,13 @@ fn determine_rp_in_ty(ty: @ast::ty,
|
||||||
// then check whether it is region-parameterized and consider
|
// then check whether it is region-parameterized and consider
|
||||||
// that as a direct dependency.
|
// that as a direct dependency.
|
||||||
match ty.node {
|
match ty.node {
|
||||||
ast::ty_path(_, id) => {
|
ast::ty_path(path, id) => {
|
||||||
match cx.def_map.get(id) {
|
match cx.def_map.get(id) {
|
||||||
ast::def_ty(did) | ast::def_class(did, _) => {
|
ast::def_ty(did) | ast::def_class(did, _) => {
|
||||||
if did.crate == ast::local_crate {
|
if did.crate == ast::local_crate {
|
||||||
cx.add_dep(did.node);
|
if cx.opt_region_is_relevant(path.rp) {
|
||||||
|
cx.add_dep(did.node);
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
let cstore = cx.sess.cstore;
|
let cstore = cx.sess.cstore;
|
||||||
match csearch::get_region_param(cstore, did) {
|
match csearch::get_region_param(cstore, did) {
|
||||||
|
@ -625,7 +642,9 @@ fn determine_rp_in_ty(ty: @ast::ty,
|
||||||
some(variance) => {
|
some(variance) => {
|
||||||
debug!("reference to external, rp'd type %s",
|
debug!("reference to external, rp'd type %s",
|
||||||
pprust::ty_to_str(ty, cx.sess.intr()));
|
pprust::ty_to_str(ty, cx.sess.intr()));
|
||||||
cx.add_rp(cx.item_id, cx.add_variance(variance))
|
if cx.opt_region_is_relevant(path.rp) {
|
||||||
|
cx.add_rp(cx.item_id, cx.add_variance(variance))
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
21
src/test/compile-fail/regions-infer-not-param.rs
Normal file
21
src/test/compile-fail/regions-infer-not-param.rs
Normal file
|
@ -0,0 +1,21 @@
|
||||||
|
struct direct {
|
||||||
|
f: ∫
|
||||||
|
}
|
||||||
|
|
||||||
|
struct indirect1 {
|
||||||
|
g: fn@(direct);
|
||||||
|
}
|
||||||
|
|
||||||
|
struct indirect2 {
|
||||||
|
g: fn@(direct/&);
|
||||||
|
}
|
||||||
|
|
||||||
|
struct indirect3 {
|
||||||
|
g: fn@(direct/&self);
|
||||||
|
}
|
||||||
|
|
||||||
|
fn take_direct(p: direct) -> direct { p } //~ ERROR mismatched types
|
||||||
|
fn take_indirect1(p: indirect1) -> indirect1 { p }
|
||||||
|
fn take_indirect2(p: indirect2) -> indirect2 { p }
|
||||||
|
fn take_indirect3(p: indirect3) -> indirect3 { p } //~ ERROR mismatched types
|
||||||
|
fn main() {}
|
Loading…
Add table
Add a link
Reference in a new issue