bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Update attributes.rs

Browse source 
Some comment refinements inspired by review feedback.
This commit is contained in:
Felix S Klock II 2019-10-03 11:08:28 +02:00 • committed by GitHub
parent e7e6dec06a
commit 5e7e8cd41f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/librustc_codegen_llvm/attributes.rs
View file

@ -281,7 +281,7 @@ pub fn from_fn_attrs(
// //
// However, in the long term we should either: // However, in the long term we should either:
// - fold this into final else (i.e. stop inspecting `id`) // - fold this into final else (i.e. stop inspecting `id`)
// - adopt Rust PR #63909. // - or, adopt Rust PR #63909.
// //
// see also Rust RFC 2753. // see also Rust RFC 2753.
@ -302,9 +302,10 @@ pub fn from_fn_attrs(
// UB otherwise. (At least for now; see also // UB otherwise. (At least for now; see also
// rust-lang/rust#63909 and Rust RFC 2753.) // rust-lang/rust#63909 and Rust RFC 2753.)
// //
// Items defined in Rust with non-Rust ABIs (case 2) are // Items defined in Rust with non-Rust ABIs (case 2) are also
// defined to not unwind. We insert shims to abort if an // not supposed to unwind. Whether this should be enforced
// unwind happens to enforce this. // (versus stating it is UB) and *how* it would be enforced
// is currently under discussion; see rust-lang/rust#58794.
// //
// In either case, we mark item as explicitly nounwind. // In either case, we mark item as explicitly nounwind.
false false