Remove a stack frame from .await calls
This commit is contained in:
parent
e6cef04457
commit
5dc8ec8dc3
5 changed files with 40 additions and 25 deletions
|
@ -77,9 +77,6 @@ where
|
|||
#[unstable(feature = "gen_future", issue = "50547")]
|
||||
#[cfg(not(bootstrap))]
|
||||
#[inline]
|
||||
pub unsafe fn poll_with_context<F>(f: Pin<&mut F>, mut cx: ResumeTy) -> Poll<F::Output>
|
||||
where
|
||||
F: Future,
|
||||
{
|
||||
F::poll(f, cx.0.as_mut())
|
||||
pub unsafe fn get_context<'a, 'b>(cx: ResumeTy) -> &'a mut Context<'b> {
|
||||
&mut *cx.0.as_ptr().cast()
|
||||
}
|
||||
|
|
|
@ -556,9 +556,9 @@ impl<'hir> LoweringContext<'_, 'hir> {
|
|||
/// ```rust
|
||||
/// match <expr> {
|
||||
/// mut pinned => loop {
|
||||
/// match unsafe { ::std::future::poll_with_context(
|
||||
/// match unsafe { ::std::future::Future::poll(
|
||||
/// <::std::pin::Pin>::new_unchecked(&mut pinned),
|
||||
/// task_context,
|
||||
/// ::std::future::get_context(task_context),
|
||||
/// ) } {
|
||||
/// ::std::task::Poll::Ready(result) => break result,
|
||||
/// ::std::task::Poll::Pending => {}
|
||||
|
@ -598,9 +598,9 @@ impl<'hir> LoweringContext<'_, 'hir> {
|
|||
let task_context_ident = Ident::with_dummy_span(sym::_task_context);
|
||||
|
||||
// unsafe {
|
||||
// ::std::future::poll_with_context(
|
||||
// ::std::future::Future::poll(
|
||||
// ::std::pin::Pin::new_unchecked(&mut pinned),
|
||||
// task_context,
|
||||
// ::std::future::get_context(task_context),
|
||||
// )
|
||||
// }
|
||||
let poll_expr = {
|
||||
|
@ -621,10 +621,15 @@ impl<'hir> LoweringContext<'_, 'hir> {
|
|||
arena_vec![self; ref_mut_pinned],
|
||||
);
|
||||
let new_unchecked = self.expr(span, new_unchecked_expr_kind, ThinVec::new());
|
||||
let call = self.expr_call_std_path(
|
||||
let get_context = self.expr_call_std_path_mut(
|
||||
gen_future_span,
|
||||
&[sym::future, sym::poll_with_context],
|
||||
arena_vec![self; new_unchecked, task_context],
|
||||
&[sym::future, sym::get_context],
|
||||
arena_vec![self; task_context],
|
||||
);
|
||||
let call = self.expr_call_std_path(
|
||||
span,
|
||||
&[sym::future, sym::Future, sym::poll],
|
||||
arena_vec![self; new_unchecked, get_context],
|
||||
);
|
||||
self.arena.alloc(self.expr_unsafe(call))
|
||||
};
|
||||
|
@ -1326,25 +1331,43 @@ impl<'hir> LoweringContext<'_, 'hir> {
|
|||
self.arena.alloc(self.expr(sp, hir::ExprKind::Tup(&[]), ThinVec::new()))
|
||||
}
|
||||
|
||||
fn expr_call_mut(
|
||||
&mut self,
|
||||
span: Span,
|
||||
e: &'hir hir::Expr<'hir>,
|
||||
args: &'hir [hir::Expr<'hir>],
|
||||
) -> hir::Expr<'hir> {
|
||||
self.expr(span, hir::ExprKind::Call(e, args), ThinVec::new())
|
||||
}
|
||||
|
||||
fn expr_call(
|
||||
&mut self,
|
||||
span: Span,
|
||||
e: &'hir hir::Expr<'hir>,
|
||||
args: &'hir [hir::Expr<'hir>],
|
||||
) -> &'hir hir::Expr<'hir> {
|
||||
self.arena.alloc(self.expr(span, hir::ExprKind::Call(e, args), ThinVec::new()))
|
||||
self.arena.alloc(self.expr_call_mut(span, e, args))
|
||||
}
|
||||
|
||||
// Note: associated functions must use `expr_call_std_path`.
|
||||
fn expr_call_std_path_mut(
|
||||
&mut self,
|
||||
span: Span,
|
||||
path_components: &[Symbol],
|
||||
args: &'hir [hir::Expr<'hir>],
|
||||
) -> hir::Expr<'hir> {
|
||||
let path =
|
||||
self.arena.alloc(self.expr_std_path(span, path_components, None, ThinVec::new()));
|
||||
self.expr_call_mut(span, path, args)
|
||||
}
|
||||
|
||||
fn expr_call_std_path(
|
||||
&mut self,
|
||||
span: Span,
|
||||
path_components: &[Symbol],
|
||||
args: &'hir [hir::Expr<'hir>],
|
||||
) -> &'hir hir::Expr<'hir> {
|
||||
let path =
|
||||
self.arena.alloc(self.expr_std_path(span, path_components, None, ThinVec::new()));
|
||||
self.expr_call(span, path, args)
|
||||
self.arena.alloc(self.expr_call_std_path_mut(span, path_components, args))
|
||||
}
|
||||
|
||||
// Create an expression calling an associated function of an std type.
|
||||
|
|
|
@ -546,8 +546,9 @@ symbols! {
|
|||
plugin,
|
||||
plugin_registrar,
|
||||
plugins,
|
||||
poll,
|
||||
Poll,
|
||||
poll_with_context,
|
||||
get_context,
|
||||
powerpc_target_feature,
|
||||
precise_pointer_size_matching,
|
||||
pref_align_of,
|
||||
|
|
|
@ -32,11 +32,8 @@ error[E0277]: the trait bound `(): std::future::Future` is not satisfied
|
|||
|
|
||||
LL | [1; ().await];
|
||||
| ^^^^^^^^ the trait `std::future::Future` is not implemented for `()`
|
||||
|
|
||||
::: $SRC_DIR/libcore/future/mod.rs:LL:COL
|
||||
|
|
||||
LL | F: Future,
|
||||
| ------ required by this bound in `std::future::poll_with_context`
|
||||
= note: required by `std::future::Future::poll`
|
||||
|
||||
error: aborting due to 5 previous errors
|
||||
|
||||
|
|
|
@ -32,11 +32,8 @@ error[E0277]: the trait bound `[closure@$DIR/issue-62009-1.rs:12:5: 12:15]: std:
|
|||
|
|
||||
LL | (|_| 2333).await;
|
||||
| ^^^^^^^^^^^^^^^^ the trait `std::future::Future` is not implemented for `[closure@$DIR/issue-62009-1.rs:12:5: 12:15]`
|
||||
|
|
||||
::: $SRC_DIR/libcore/future/mod.rs:LL:COL
|
||||
|
|
||||
LL | F: Future,
|
||||
| ------ required by this bound in `std::future::poll_with_context`
|
||||
= note: required by `std::future::Future::poll`
|
||||
|
||||
error: aborting due to 4 previous errors
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue