bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #139176 - m-ou-se:print3, r=compiler-errors

Browse source 
Remove fragile equal-pointers-unequal/*/print3.rs tests.

These tests were added in #127003

The print3.rs tests stop working when I change implementation details of format_args!(). (For example, in https://github.com/rust-lang/rust/pull/139175 and https://github.com/rust-lang/rust/pull/139135). These tests shouldn't rely on such implementation details. It gets in the way for format_args!() improvements.

If they test anything that aren't already covered by the other tests in this directory, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!().

cc ``@GrigorenkoPV,`` author of these tests.
This commit is contained in:
Matthias Krüger 2025-03-31 23:05:46 +02:00 • committed by GitHub
commit 5b46e2462a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/ui/codegen/equal-pointers-unequal/as-cast/print3.rs
View file

@ -1,23 +0,0 @@
//@ known-bug: #107975
//@ compile-flags: -Copt-level=2
//@ run-pass
// https://github.com/rust-lang/rust/issues/107975#issuecomment-1430704499
fn main() {
let a = {
let v = 0;
&v as *const _ as usize
};
let b = {
let v = 0;
&v as *const _ as usize
};
assert_ne!(a, b);
assert_ne!(a, b);
let c = a;
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "false true false");
println!("{a} {b}");
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "true true true");
}

25
tests/ui/codegen/equal-pointers-unequal/exposed-provenance/print3.rs
View file

@ -1,25 +0,0 @@
//@ known-bug: #107975
//@ compile-flags: -Copt-level=2
//@ run-pass
// https://github.com/rust-lang/rust/issues/107975#issuecomment-1430704499
use std::ptr;
fn main() {
let a: usize = {
let v = 0;
ptr::from_ref(&v).expose_provenance()
};
let b: usize = {
let v = 0;
ptr::from_ref(&v).expose_provenance()
};
assert_ne!(a, b);
assert_ne!(a, b);
let c = a;
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "false true false");
println!("{a} {b}");
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "true true true");
}

25
tests/ui/codegen/equal-pointers-unequal/strict-provenance/print3.rs
View file

@ -1,25 +0,0 @@
//@ known-bug: #107975
//@ compile-flags: -Copt-level=2
//@ run-pass
// https://github.com/rust-lang/rust/issues/107975#issuecomment-1430704499
use std::ptr;
fn main() {
let a: usize = {
let v = 0;
ptr::from_ref(&v).addr()
};
let b: usize = {
let v = 0;
ptr::from_ref(&v).addr()
};
assert_ne!(a, b);
assert_ne!(a, b);
let c = a;
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "false true false");
println!("{a} {b}");
assert_eq!(format!("{} {} {}", a == b, a == c, b == c), "true true true");
}