bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove leading underscores from parameter names in Sharded

Browse source 
With the removal of `cfg(parallel_compiler)`, these parameters are never
considered unused.
This commit is contained in:
Zalathar 2025-03-02 17:49:15 +11:00
parent 81d8edc200
commit 5afd12239a
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/rustc_data_structures/src/sharded.rs
View file

@ -43,10 +43,10 @@ impl<T> Sharded<T> {
/// The shard is selected by hashing `val` with `FxHasher`. /// The shard is selected by hashing `val` with `FxHasher`.
#[inline] #[inline]
pub fn get_shard_by_value<K: Hash + ?Sized>(&self, _val: &K) -> &Lock<T> { pub fn get_shard_by_value<K: Hash + ?Sized>(&self, val: &K) -> &Lock<T> {
match self { match self {
Self::Single(single) => single, Self::Single(single) => single,
Self::Shards(..) => self.get_shard_by_hash(make_hash(_val)), Self::Shards(..) => self.get_shard_by_hash(make_hash(val)),
} }
} }
@ -56,12 +56,12 @@ impl<T> Sharded<T> {
} }
#[inline] #[inline]
pub fn get_shard_by_index(&self, _i: usize) -> &Lock<T> { pub fn get_shard_by_index(&self, i: usize) -> &Lock<T> {
match self { match self {
Self::Single(single) => single, Self::Single(single) => single,
Self::Shards(shards) => { Self::Shards(shards) => {
// SAFETY: The index gets ANDed with the shard mask, ensuring it is always inbounds. // SAFETY: The index gets ANDed with the shard mask, ensuring it is always inbounds.
unsafe { &shards.get_unchecked(_i & (SHARDS - 1)).0 } unsafe { &shards.get_unchecked(i & (SHARDS - 1)).0 }
} }
} }
} }
@ -69,7 +69,7 @@ impl<T> Sharded<T> {
/// The shard is selected by hashing `val` with `FxHasher`. /// The shard is selected by hashing `val` with `FxHasher`.
#[inline] #[inline]
#[track_caller] #[track_caller]
pub fn lock_shard_by_value<K: Hash + ?Sized>(&self, _val: &K) -> LockGuard<'_, T> { pub fn lock_shard_by_value<K: Hash + ?Sized>(&self, val: &K) -> LockGuard<'_, T> {
match self { match self {
Self::Single(single) => { Self::Single(single) => {
// Synchronization is disabled so use the `lock_assume_no_sync` method optimized // Synchronization is disabled so use the `lock_assume_no_sync` method optimized
@ -79,7 +79,7 @@ impl<T> Sharded<T> {
// `might_be_dyn_thread_safe` was also false. // `might_be_dyn_thread_safe` was also false.
unsafe { single.lock_assume(Mode::NoSync) } unsafe { single.lock_assume(Mode::NoSync) }
} }
Self::Shards(..) => self.lock_shard_by_hash(make_hash(_val)), Self::Shards(..) => self.lock_shard_by_hash(make_hash(val)),
} }
} }
@ -91,7 +91,7 @@ impl<T> Sharded<T> {
#[inline] #[inline]
#[track_caller] #[track_caller]
pub fn lock_shard_by_index(&self, _i: usize) -> LockGuard<'_, T> { pub fn lock_shard_by_index(&self, i: usize) -> LockGuard<'_, T> {
match self { match self {
Self::Single(single) => { Self::Single(single) => {
// Synchronization is disabled so use the `lock_assume_no_sync` method optimized // Synchronization is disabled so use the `lock_assume_no_sync` method optimized
@ -109,7 +109,7 @@ impl<T> Sharded<T> {
// always inbounds. // always inbounds.
// SAFETY (lock_assume_sync): We know `is_dyn_thread_safe` was true when creating // SAFETY (lock_assume_sync): We know `is_dyn_thread_safe` was true when creating
// the lock thus `might_be_dyn_thread_safe` was also true. // the lock thus `might_be_dyn_thread_safe` was also true.
unsafe { shards.get_unchecked(_i & (SHARDS - 1)).0.lock_assume(Mode::Sync) } unsafe { shards.get_unchecked(i & (SHARDS - 1)).0.lock_assume(Mode::Sync) }
} }
} }
} }