bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

fix(rustc_lint): better detect when parens are necessary

Browse source 
Fixes #88519
This commit is contained in:
Michael Howell 2021-08-31 14:45:57 -07:00
parent c2a408840a
commit 59b245e754
2 changed files with 104 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
compiler/rustc_lint/src/unused.rs
View file

@ -461,13 +461,16 @@ trait UnusedDelimLint {
let lhs_needs_parens = {
let mut innermost = inner;
loop {
if let ExprKind::Binary(_, lhs, _rhs) = &innermost.kind {
innermost = lhs;
if !classify::expr_requires_semi_to_be_stmt(innermost) {
break true;
}
} else {
break false;
innermost = match &innermost.kind {
ExprKind::Binary(_, lhs, _rhs) => lhs,
ExprKind::Call(fn_, _params) => fn_,
ExprKind::Cast(expr, _ty) => expr,
ExprKind::Type(expr, _ty) => expr,
ExprKind::Index(base, _subscript) => base,
_ => break false,
};
if !classify::expr_requires_semi_to_be_stmt(innermost) {
break true;
}
}
};