WIP compiles and doesn't crash (much) but tests are failing
This commit is contained in:
parent
f9fe50da1e
commit
59b0077565
47 changed files with 387 additions and 347 deletions
|
@ -35,9 +35,9 @@ impl LateLintPass for OverflowCheckConditional {
|
|||
if_let_chain! {[
|
||||
let Expr_::ExprBinary(ref op, ref first, ref second) = expr.node,
|
||||
let Expr_::ExprBinary(ref op2, ref ident1, ref ident2) = first.node,
|
||||
let Expr_::ExprPath(_,ref path1) = ident1.node,
|
||||
let Expr_::ExprPath(_, ref path2) = ident2.node,
|
||||
let Expr_::ExprPath(_, ref path3) = second.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path1)) = ident1.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path2)) = ident2.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path3)) = second.node,
|
||||
&path1.segments[0] == &path3.segments[0] || &path2.segments[0] == &path3.segments[0],
|
||||
cx.tcx.tables().expr_ty(ident1).is_integral(),
|
||||
cx.tcx.tables().expr_ty(ident2).is_integral()
|
||||
|
@ -57,9 +57,9 @@ impl LateLintPass for OverflowCheckConditional {
|
|||
if_let_chain! {[
|
||||
let Expr_::ExprBinary(ref op, ref first, ref second) = expr.node,
|
||||
let Expr_::ExprBinary(ref op2, ref ident1, ref ident2) = second.node,
|
||||
let Expr_::ExprPath(_,ref path1) = ident1.node,
|
||||
let Expr_::ExprPath(_, ref path2) = ident2.node,
|
||||
let Expr_::ExprPath(_, ref path3) = first.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path1)) = ident1.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path2)) = ident2.node,
|
||||
let Expr_::ExprPath(QPath::Resolved(_, ref path3)) = first.node,
|
||||
&path1.segments[0] == &path3.segments[0] || &path2.segments[0] == &path3.segments[0],
|
||||
cx.tcx.tables().expr_ty(ident1).is_integral(),
|
||||
cx.tcx.tables().expr_ty(ident2).is_integral()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue