bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Add FIXME for auditing optional parameters passed to DIBuilder

Browse source
This commit is contained in:
Zalathar 2024-12-08 00:10:39 +11:00
parent 8ddd9c38f6
commit 5413d2bd6f
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_codegen_llvm/src/llvm/ffi.rs
View file

@ -1712,6 +1712,10 @@ unsafe extern "C" {
// FFI bindings for `DIBuilder` functions in the LLVM-C API.
// Try to keep these in the same order as in `llvm/include/llvm-c/DebugInfo.h`.
//
// FIXME(#134001): Audit all `Option` parameters, especially in lists, to check
// that they really are nullable on the C/C++ side. LLVM doesn't appear to
// actually document which ones are nullable.
unsafe extern "C" {
pub(crate) fn LLVMCreateDIBuilder<'ll>(M: &'ll Module) -> *mut DIBuilder<'ll>;
pub(crate) fn LLVMDisposeDIBuilder<'ll>(Builder: ptr::NonNull<DIBuilder<'ll>>);