bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add a suggestion when using a type alias instead of trait alias

Browse source
This commit is contained in:
Yuki Okushi 2021-04-01 08:37:29 +09:00
parent a5029ac0ab
commit 539242a07b
8 changed files with 61 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_resolve/src/late/diagnostics.rs
View file

@ -928,7 +928,14 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> {
let msg = "you might have meant to use `#![feature(trait_alias)]` instead of a \
`type` alias";
if let Some(span) = self.def_span(def_id) {
err.span_help(span, msg);
if let Ok(snip) = self.r.session.source_map().span_to_snippet(span) {
// The span contains a type alias so we should be able to
// replace `type` with `trait`.
let snip = snip.replacen("type", "trait", 1);
err.span_suggestion(span, msg, snip, Applicability::MaybeIncorrect);
} else {
err.span_help(span, msg);
}
} else {
err.help(msg);
}