bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Suggest removing the non-printing characters

Browse source
This commit is contained in:
5225225 2021-11-13 12:46:22 +00:00
parent de05d3ec31
commit 52199c93bb
3 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
compiler/rustc_parse/src/lexer/unescape_error_reporting.rs
View file

@ -7,6 +7,10 @@ use rustc_errors::{pluralize, Applicability, Handler};
use rustc_lexer::unescape::{EscapeError, Mode};
use rustc_span::{BytePos, Span};
fn printing(ch: char) -> bool {
unicode_width::UnicodeWidthChar::width(ch).unwrap_or(0) != 0 && !ch.is_whitespace()
}
pub(crate) fn emit_unescape_error(
handler: &Handler,
// interior part of the literal, without quotes
@ -83,7 +87,11 @@ pub(crate) fn emit_unescape_error(
);
}
} else {
if lit.chars().filter(|x| x.is_whitespace() || x.is_control()).count() >= 1 {
let printable: Vec<char> = lit.chars().filter(|x| printing(*x)).collect();
if let [ch] = printable.as_slice() {
has_help = true;
handler.span_note(
span,
&format!(
@ -91,6 +99,13 @@ pub(crate) fn emit_unescape_error(
lit.escape_default(),
),
);
handler.span_suggestion(
span,
"consider removing the non-printing characters",
ch.to_string(),
Applicability::MaybeIncorrect,
);
}
}