1
Fork 0

Fix text overlap

This commit is contained in:
Guillaume Gomez 2018-03-28 09:00:58 +02:00
parent 14ac1b5faa
commit 51f26acaea
9 changed files with 55 additions and 32 deletions

View file

@ -2243,14 +2243,7 @@ fn item_function(w: &mut fmt::Formatter, cx: &Context, it: &clean::Item,
fn render_implementor(cx: &Context, implementor: &Impl, w: &mut fmt::Formatter, fn render_implementor(cx: &Context, implementor: &Impl, w: &mut fmt::Formatter,
implementor_dups: &FxHashMap<&str, (DefId, bool)>) -> Result<(), fmt::Error> { implementor_dups: &FxHashMap<&str, (DefId, bool)>) -> Result<(), fmt::Error> {
write!(w, "<li>")?; write!(w, "<li><table class='table-display'><tbody><tr><td><code>")?;
if let Some(l) = (Item { cx, item: &implementor.impl_item }).src_href() {
write!(w, "<div class='out-of-band'>")?;
write!(w, "<a class='srclink' href='{}' title='{}'>[src]</a>",
l, "goto source code")?;
write!(w, "</div>")?;
}
write!(w, "<code>")?;
// If there's already another implementor that has the same abbridged name, use the // If there's already another implementor that has the same abbridged name, use the
// full path, for example in `std::iter::ExactSizeIterator` // full path, for example in `std::iter::ExactSizeIterator`
let use_absolute = match implementor.inner_impl().for_ { let use_absolute = match implementor.inner_impl().for_ {
@ -2269,7 +2262,14 @@ fn render_implementor(cx: &Context, implementor: &Impl, w: &mut fmt::Formatter,
write!(w, ";</span>")?; write!(w, ";</span>")?;
} }
} }
writeln!(w, "</code></li>")?; write!(w, "</code><td>")?;
if let Some(l) = (Item { cx, item: &implementor.impl_item }).src_href() {
write!(w, "<div class='out-of-band'>")?;
write!(w, "<a class='srclink' href='{}' title='{}'>[src]</a>",
l, "goto source code")?;
write!(w, "</div>")?;
}
writeln!(w, "</td></tr></tbody></table></li>")?;
Ok(()) Ok(())
} }
@ -3314,10 +3314,11 @@ fn render_impl(w: &mut fmt::Formatter, cx: &Context, i: &Impl, link: AssocItemLi
Some(ref t) => format!("impl-{}", small_url_encode(&format!("{:#}", t))), Some(ref t) => format!("impl-{}", small_url_encode(&format!("{:#}", t))),
None => "impl".to_string(), None => "impl".to_string(),
}); });
write!(w, "<h3 id='{}' class='impl'><span class='in-band'><code>{}</code>", write!(w, "<h3 id='{}' class='impl'><span class='in-band'><table class='table-display'>\
<tbody><tr><td><code>{}</code>",
id, i.inner_impl())?; id, i.inner_impl())?;
write!(w, "<a href='#{}' class='anchor'></a>", id)?; write!(w, "<a href='#{}' class='anchor'></a>", id)?;
write!(w, "</span><span class='out-of-band'>")?; write!(w, "</span></td><td><span class='out-of-band'>")?;
let since = i.impl_item.stability.as_ref().map(|s| &s.since[..]); let since = i.impl_item.stability.as_ref().map(|s| &s.since[..]);
if let Some(l) = (Item { item: &i.impl_item, cx: cx }).src_href() { if let Some(l) = (Item { item: &i.impl_item, cx: cx }).src_href() {
write!(w, "<div class='ghost'></div>")?; write!(w, "<div class='ghost'></div>")?;
@ -3327,8 +3328,7 @@ fn render_impl(w: &mut fmt::Formatter, cx: &Context, i: &Impl, link: AssocItemLi
} else { } else {
render_stability_since_raw(w, since, outer_version)?; render_stability_since_raw(w, since, outer_version)?;
} }
write!(w, "</span>")?; write!(w, "</span></td></tr></tbody></table></h3>")?;
write!(w, "</h3>\n")?;
if let Some(ref dox) = cx.shared.maybe_collapsed_doc_value(&i.impl_item) { if let Some(ref dox) = cx.shared.maybe_collapsed_doc_value(&i.impl_item) {
write!(w, "<div class='docblock'>{}</div>", write!(w, "<div class='docblock'>{}</div>",
Markdown(&*dox, &i.impl_item.links()))?; Markdown(&*dox, &i.impl_item.links()))?;
@ -3357,19 +3357,20 @@ fn render_impl(w: &mut fmt::Formatter, cx: &Context, i: &Impl, link: AssocItemLi
write!(w, "<h4 id='{}' class=\"{}\">", id, item_type)?; write!(w, "<h4 id='{}' class=\"{}\">", id, item_type)?;
write!(w, "{}", spotlight_decl(decl)?)?; write!(w, "{}", spotlight_decl(decl)?)?;
write!(w, "<span id='{}' class='invisible'>", ns_id)?; write!(w, "<span id='{}' class='invisible'>", ns_id)?;
write!(w, "<code>")?; write!(w, "<table class='table-display'><tbody><tr><td><code>")?;
render_assoc_item(w, item, link.anchor(&id), ItemType::Impl)?; render_assoc_item(w, item, link.anchor(&id), ItemType::Impl)?;
write!(w, "</code>")?; write!(w, "</code>")?;
if let Some(l) = (Item { cx, item }).src_href() { if let Some(l) = (Item { cx, item }).src_href() {
write!(w, "</span><span class='out-of-band'>")?; write!(w, "</span></td><td><span class='out-of-band'>")?;
write!(w, "<div class='ghost'></div>")?; write!(w, "<div class='ghost'></div>")?;
render_stability_since_raw(w, item.stable_since(), outer_version)?; render_stability_since_raw(w, item.stable_since(), outer_version)?;
write!(w, "<a class='srclink' href='{}' title='{}'>[src]</a>", write!(w, "<a class='srclink' href='{}' title='{}'>[src]</a>",
l, "goto source code")?; l, "goto source code")?;
} else { } else {
write!(w, "</td><td>")?;
render_stability_since_raw(w, item.stable_since(), outer_version)?; render_stability_since_raw(w, item.stable_since(), outer_version)?;
} }
write!(w, "</span></h4>\n")?; write!(w, "</td></tr></tbody></table></span></h4>")?;
} }
} }
clean::TypedefItem(ref tydef, _) => { clean::TypedefItem(ref tydef, _) => {

View file

@ -387,8 +387,6 @@ h4 > code, h3 > code, .invisible > code {
.content .in-band { .content .in-band {
margin: 0px; margin: 0px;
padding: 0px; padding: 0px;
display: inline-block;
max-width: calc(100% - 43px);
} }
.in-band > code { .in-band > code {
@ -403,7 +401,7 @@ h4 > code, h3 > code, .invisible > code {
font-family: "Fira Sans", "Helvetica Neue", Helvetica, Arial, sans-serif; font-family: "Fira Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
} }
.content table { .content table:not(.table-display) {
border-spacing: 0 5px; border-spacing: 0 5px;
border-collapse: separate; border-collapse: separate;
} }
@ -470,7 +468,6 @@ h4 > code, h3 > code, .invisible > code {
.content .methods > div:not(.important-traits) { margin-left: 40px; } .content .methods > div:not(.important-traits) { margin-left: 40px; }
.content .impl-items .docblock, .content .impl-items .stability { .content .impl-items .docblock, .content .impl-items .stability {
margin-left: 40px;
margin-bottom: .6em; margin-bottom: .6em;
} }
.content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant { .content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant {
@ -1254,3 +1251,28 @@ kbd {
/* important because of conflicting rule for small screens */ /* important because of conflicting rule for small screens */
display: none !important; display: none !important;
} }
#implementations-list > h3 > span.in-band {
width: 100%;
}
.table-display {
width: 100%;
border: 0;
border-collapse: collapse;
border-spacing: 0;
font-size: 16px;
}
.table-display tr td:first-child {
padding-right: 0;
}
.table-display tr td:last-child {
float: right;
}
.table-display .out-of-band {
position: relative;
font-size: 19px;
display: block;
}

View file

@ -30,7 +30,7 @@ mod foo {
} }
// @has complex/struct.NotOuter.html // @has complex/struct.NotOuter.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<'a, T, K: \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'a, T, K: \
// ?Sized> Send for NotOuter<'a, T, K> where K: for<'b> Fn((&'b bool, &'a u8)) \ // ?Sized> Send for NotOuter<'a, T, K> where K: for<'b> Fn((&'b bool, &'a u8)) \
// -> &'b i8, T: MyTrait<'a>, <T as MyTrait<'a>>::MyItem: Copy, 'a: 'static" // -> &'b i8, T: MyTrait<'a>, <T as MyTrait<'a>>::MyItem: Copy, 'a: 'static"

View file

@ -18,10 +18,10 @@ where
{} {}
// @has lifetimes/struct.Foo.html // @has lifetimes/struct.Foo.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<'c, K> Send \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'c, K> Send \
// for Foo<'c, K> where K: for<'b> Fn(&'b bool) -> &'c u8, 'c: 'static" // for Foo<'c, K> where K: for<'b> Fn(&'b bool) -> &'c u8, 'c: 'static"
// //
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<'c, K> Sync \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'c, K> Sync \
// for Foo<'c, K> where K: Sync" // for Foo<'c, K> where K: Sync"
pub struct Foo<'c, K: 'c> { pub struct Foo<'c, K: 'c> {
inner_field: Inner<'c, K>, inner_field: Inner<'c, K>,

View file

@ -9,10 +9,10 @@
// except according to those terms. // except according to those terms.
// @has manual/struct.Foo.html // @has manual/struct.Foo.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' 'impl<T> Sync for \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' 'impl<T> Sync for \
// Foo<T> where T: Sync' // Foo<T> where T: Sync'
// //
// @has - '//*[@id="implementations-list"]/*[@class="impl"]/*/code' \ // @has - '//*[@id="implementations-list"]/*[@class="impl"]//*/code' \
// 'impl<T> Send for Foo<T>' // 'impl<T> Send for Foo<T>'
// //
// @count - '//*[@id="implementations-list"]/*[@class="impl"]' 1 // @count - '//*[@id="implementations-list"]/*[@class="impl"]' 1

View file

@ -13,10 +13,10 @@ pub struct Inner<T: Copy> {
} }
// @has negative/struct.Outer.html // @has negative/struct.Outer.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<T> !Send for \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<T> !Send for \
// Outer<T>" // Outer<T>"
// //
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<T> \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<T> \
// !Sync for Outer<T>" // !Sync for Outer<T>"
pub struct Outer<T: Copy> { pub struct Outer<T: Copy> {
inner_field: Inner<T>, inner_field: Inner<T>,

View file

@ -18,10 +18,10 @@ where
} }
// @has nested/struct.Foo.html // @has nested/struct.Foo.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' 'impl<T> Send for \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' 'impl<T> Send for \
// Foo<T> where T: Copy' // Foo<T> where T: Copy'
// //
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' \
// 'impl<T> Sync for Foo<T> where T: Sync' // 'impl<T> Sync for Foo<T> where T: Sync'
pub struct Foo<T> { pub struct Foo<T> {
inner_field: Inner<T>, inner_field: Inner<T>,

View file

@ -19,7 +19,7 @@ where
} }
// @has no_redundancy/struct.Outer.html // @has no_redundancy/struct.Outer.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<T> Send for \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<T> Send for \
// Outer<T> where T: Copy + Send" // Outer<T> where T: Copy + Send"
pub struct Outer<T> { pub struct Outer<T> {
inner_field: Inner<T>, inner_field: Inner<T>,

View file

@ -33,10 +33,10 @@ where
} }
// @has project/struct.Foo.html // @has project/struct.Foo.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<'c, K> Send \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'c, K> Send \
// for Foo<'c, K> where K: MyTrait<MyItem = bool>, 'c: 'static" // for Foo<'c, K> where K: MyTrait<MyItem = bool>, 'c: 'static"
// //
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]/*/code' "impl<'c, K> Sync \ // @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'c, K> Sync \
// for Foo<'c, K> where K: MyTrait, <K as MyTrait>::MyItem: OtherTrait, 'c: 'static," // for Foo<'c, K> where K: MyTrait, <K as MyTrait>::MyItem: OtherTrait, 'c: 'static,"
pub struct Foo<'c, K: 'c> { pub struct Foo<'c, K: 'c> {
inner_field: Inner<'c, K>, inner_field: Inner<'c, K>,