bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

remove an unnecessary span_to_snippet

Browse source
This commit is contained in:
Takayuki Maeda 2022-07-13 13:24:06 +09:00
parent 1c7b36d4db
commit 5188bdbccd
1 changed files with 9 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs
View file

@ -1598,21 +1598,18 @@ impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {
let return_ty = tcx.erase_regions(return_ty); let return_ty = tcx.erase_regions(return_ty);
// to avoid panics // to avoid panics
if let Some(iter_trait) = tcx.get_diagnostic_item(sym::Iterator) { if let Some(iter_trait) = tcx.get_diagnostic_item(sym::Iterator)
if self && self
.infcx .infcx
.type_implements_trait(iter_trait, return_ty, ty_params, self.param_env) .type_implements_trait(iter_trait, return_ty, ty_params, self.param_env)
.must_apply_modulo_regions() .must_apply_modulo_regions()
{ {
if let Ok(snippet) = tcx.sess.source_map().span_to_snippet(return_span) { err.span_suggestion_hidden(
err.span_suggestion_hidden( return_span.shrink_to_hi(),
return_span, "use `.collect()` to allocate the iterator",
"use `.collect()` to allocate the iterator", ".collect::<Vec<_>>()",
format!("{snippet}.collect::<Vec<_>>()"), Applicability::MaybeIncorrect,
Applicability::MaybeIncorrect, );
);
}
}
} }
} }