Rollup merge of #86657 - jam1garner:future_prelude_false_positive, r=nikomatsakis
Fix `future_prelude_collision` false positive Fixes #86633 The lint for checking if method resolution of methods named `try_into` will fail in 2021 edition previously would fire on all inherent methods, however for inherent methods that consume `self`, this takes priority over `TryInto::try_into` due to being inherent, while trait method and methods that take `&self` or `&mut self` don't take priority, and thus aren't affected by this false positive. This fix is rather simple: simply checking if the inherent method doesn't auto-deref or auto-ref (and thus takes `self`) and if so, prevents the lint from firing.
This commit is contained in:
commit
5028581a1f
2 changed files with 23 additions and 0 deletions
|
@ -57,6 +57,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
|
|||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// if it's an inherent `self` method (not `&self` or `&mut self`), it will take
|
||||
// precedence over the `TryInto` impl, and thus won't break in 2021 edition
|
||||
if pick.autoderefs == 0 && pick.autoref_or_ptr_adjustment.is_none() {
|
||||
return;
|
||||
}
|
||||
|
||||
// Inherent impls only require not relying on autoref and autoderef in order to
|
||||
// ensure that the trait implementation won't be used
|
||||
self.tcx.struct_span_lint_hir(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue