address review
This commit is contained in:
parent
84bcd40927
commit
4d9a0bf21b
3 changed files with 10 additions and 1 deletions
|
@ -1644,6 +1644,11 @@ rustc_queries! {
|
||||||
desc { "normalizing `{:?}`", goal }
|
desc { "normalizing `{:?}`", goal }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// FIXME: Implement `normalize_generic_arg_after_erasing_regions` and
|
||||||
|
// `normalize_mir_const_after_erasing_regions` in terms of
|
||||||
|
// `try_normalize_generic_arg_after_erasing_regions` and
|
||||||
|
// `try_normalize_mir_const_after_erasing_regions`, respectively.
|
||||||
|
|
||||||
/// Do not call this query directly: invoke `normalize_erasing_regions` instead.
|
/// Do not call this query directly: invoke `normalize_erasing_regions` instead.
|
||||||
query normalize_generic_arg_after_erasing_regions(
|
query normalize_generic_arg_after_erasing_regions(
|
||||||
goal: ParamEnvAnd<'tcx, GenericArg<'tcx>>
|
goal: ParamEnvAnd<'tcx, GenericArg<'tcx>>
|
||||||
|
|
|
@ -240,6 +240,10 @@ fn layout_of<'tcx>(
|
||||||
let param_env = param_env.with_reveal_all_normalized(tcx);
|
let param_env = param_env.with_reveal_all_normalized(tcx);
|
||||||
let unnormalized_ty = ty;
|
let unnormalized_ty = ty;
|
||||||
|
|
||||||
|
// FIXME: We might want to have two different versions of `layout_of`:
|
||||||
|
// One that can be called after typecheck has completed and can use
|
||||||
|
// `normalize_erasing_regions` here and another one that can be called
|
||||||
|
// before typecheck has completed and uses `try_normalize_erasing_regions`.
|
||||||
let ty = match tcx.try_normalize_erasing_regions(param_env, ty) {
|
let ty = match tcx.try_normalize_erasing_regions(param_env, ty) {
|
||||||
Ok(t) => t,
|
Ok(t) => t,
|
||||||
Err(normalization_error) => {
|
Err(normalization_error) => {
|
||||||
|
|
|
@ -1773,7 +1773,7 @@ fn document_type_layout(w: &mut Buffer, cx: &Context<'_>, ty_def_id: DefId) {
|
||||||
writeln!(
|
writeln!(
|
||||||
w,
|
w,
|
||||||
"<p><strong>Note:</strong> Encountered an error during type layout; \
|
"<p><strong>Note:</strong> Encountered an error during type layout; \
|
||||||
the type was not normalizable.</p>"
|
the type failed to be normalized.</p>"
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue