bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

simplify-locals: Remove unused assignments regardless of rvalue kind

Browse source
This commit is contained in:
Tomasz Miąsko 2020-10-17 00:00:00 +00:00
parent 52d3782685
commit 4c3e06a0ba
13 changed files with 36 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

26
compiler/rustc_mir/src/transform/simplify.rs
View file

@ -439,31 +439,7 @@ impl Visitor<'_> for UsedLocals {
StatementKind::StorageLive(_local) | StatementKind::StorageDead(_local) => {}
StatementKind::Assign(box (ref place, ref rvalue)) => {
let can_skip = match rvalue {
Rvalue::Use(_)
| Rvalue::Discriminant(_)
| Rvalue::BinaryOp(_, _, _)
| Rvalue::CheckedBinaryOp(_, _, _)
| Rvalue::Repeat(_, _)
| Rvalue::AddressOf(_, _)
| Rvalue::Len(_)
| Rvalue::UnaryOp(_, _)
| Rvalue::Aggregate(_, _) => true,
Rvalue::Ref(..)
| Rvalue::ThreadLocalRef(..)
| Rvalue::Cast(..)
| Rvalue::NullaryOp(..) => false,
};
if can_skip {
self.visit_lhs(place, location);
} else {
self.visit_place(
place,
PlaceContext::MutatingUse(MutatingUseContext::Store),
location,
);
}
self.visit_lhs(place, location);
self.visit_rvalue(rvalue, location);
}