bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #133163 - RalfJung:cold, r=saethlin

Browse source 
remove pointless cold_path impl in interpreter

This has a fallback impl so the interpreter impl is not needed.

r? ``@saethlin``
This commit is contained in:
Guillaume Gomez 2024-11-18 17:17:43 +01:00 • committed by GitHub
commit 4baf540fce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs
View file

@ -1264,6 +1264,7 @@ fn codegen_regular_intrinsic_call<'tcx>(
sym::cold_path => { sym::cold_path => {
// This is a no-op. The intrinsic is just a hint to the optimizer. // This is a no-op. The intrinsic is just a hint to the optimizer.
// We still have an impl here to avoid it being turned into a call.
} }
// Unimplemented intrinsics must have a fallback body. The fallback body is obtained // Unimplemented intrinsics must have a fallback body. The fallback body is obtained

3
compiler/rustc_const_eval/src/interpret/intrinsics.rs
View file

@ -417,9 +417,6 @@ impl<'tcx, M: Machine<'tcx>> InterpCx<'tcx, M> {
// These just return their argument // These just return their argument
self.copy_op(&args[0], dest)?; self.copy_op(&args[0], dest)?;
} }
sym::cold_path => {
// This is a no-op. The intrinsic is just a hint to the optimizer.
}
sym::raw_eq => { sym::raw_eq => {
let result = self.raw_eq_intrinsic(&args[0], &args[1])?; let result = self.raw_eq_intrinsic(&args[0], &args[1])?;
self.write_scalar(result, dest)?; self.write_scalar(result, dest)?;