bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add FIXME note about storing &'tcx str

Browse source
This commit is contained in:
jumbatm 2020-12-23 00:34:26 +10:00
parent 7a46a4f219
commit 4b740acea2
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_lint/src/builtin.rs
View file

@ -2596,6 +2596,11 @@ declare_lint! {
} }
pub struct ClashingExternDeclarations { pub struct ClashingExternDeclarations {
/// Map of function symbol name to the first-seen hir id for that symbol name.. If seen_decls
/// contains an entry for key K, it means a symbol with name K has been seen by this lint and
/// the symbol should be reported as a clashing declaration.
// FIXME: Technically, we could just store a &'tcx str here without issue; however, the
// `impl_lint_pass` macro doesn't currently support lints parametric over a lifetime.
seen_decls: FxHashMap<String, HirId>, seen_decls: FxHashMap<String, HirId>,
} }