bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add a FIXME explaining how one could go about fixing this code to bring it in

Browse source 
sync with the method added in PR 94584.
This commit is contained in:
Felix S. Klock II 2022-03-07 17:17:15 -05:00
parent 673640d26d
commit 4a0c2b2aba
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_typeck/src/check/method/suggest.rs
View file

@ -1936,6 +1936,10 @@ pub fn all_traits(tcx: TyCtxt<'_>) -> Vec<TraitInfo> {
} }
fn find_use_placement<'tcx>(tcx: TyCtxt<'tcx>, target_module: LocalDefId) -> (Option<Span>, bool) { fn find_use_placement<'tcx>(tcx: TyCtxt<'tcx>, target_module: LocalDefId) -> (Option<Span>, bool) {
// FIXME(#94854): this code uses an out-of-date method for inferring a span
// to suggest. It would be better to thread the ModSpans from the AST into
// the HIR, and then use that to drive the suggestion here.
let mut span = None; let mut span = None;
let mut found_use = false; let mut found_use = false;
let (module, _, _) = tcx.hir().get_module(target_module); let (module, _, _) = tcx.hir().get_module(target_module);