bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #8287 - Jarcho:iter_not_returning_iterator_8285, r=Manishearth

Browse source 
Erase late bound regions in `iter_not_returning_iterator`

fixes #8285

changelog: None
This commit is contained in:
bors 2022-01-15 05:31:46 +00:00
commit 496f26c229
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/iter_not_returning_iterator.rs
View file

@ -66,7 +66,7 @@ impl<'tcx> LateLintPass<'tcx> for IterNotReturningIterator {
fn check_sig(cx: &LateContext<'_>, name: &str, sig: &FnSig<'_>, fn_id: LocalDefId) { fn check_sig(cx: &LateContext<'_>, name: &str, sig: &FnSig<'_>, fn_id: LocalDefId) {
if sig.decl.implicit_self.has_implicit_self() { if sig.decl.implicit_self.has_implicit_self() {
let ret_ty = cx.tcx.fn_sig(fn_id).skip_binder().output(); let ret_ty = cx.tcx.erase_late_bound_regions(cx.tcx.fn_sig(fn_id).output());
let ret_ty = cx let ret_ty = cx
.tcx .tcx
.try_normalize_erasing_regions(cx.param_env, ret_ty) .try_normalize_erasing_regions(cx.param_env, ret_ty)

7
tests/ui/iter_not_returning_iterator.rs
View file

@ -64,4 +64,11 @@ impl S {
} }
} }
struct S2([u8]);
impl S2 {
fn iter(&self) -> core::slice::Iter<u8> {
self.0.iter()
}
}
fn main() {} fn main() {}