bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Adjust wording for review

Browse source
This commit is contained in:
Jack Huey 2021-12-13 10:06:57 -05:00
parent 7cbd0dcf93
commit 48974158f1
3 changed files with 33 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_typeck/src/check/wfcheck.rs
View file

@ -487,9 +487,12 @@ fn check_gat_where_clauses(
);
let bound = if clauses.len() > 1 { "these bounds are" } else { "this bound is" };
err.note(&format!("{} required to ensure that impls have maximum flexibility", bound));
err.note(&format!(
"{} currently required to ensure that impls have maximum flexibility",
bound
));
err.note(
"see issue #87479 \
"we are soliciting feedback, see issue #87479 \
<https://github.com/rust-lang/rust/issues/87479> \
for more information",
);

4
src/test/ui/generic-associated-types/issue-86787.stderr
View file

@ -6,8 +6,8 @@ LL | type TRef<'a>;
| |
| help: add the required where clause: `where Self: 'a`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: aborting due to previous error

52
src/test/ui/generic-associated-types/self-outlives-lint.stderr
View file

@ -6,8 +6,8 @@ LL | type Item<'x>;
| |
| help: add the required where clause: `where Self: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Out`
--> $DIR/self-outlives-lint.rs:25:5
@ -17,8 +17,8 @@ LL | type Out<'x>;
| |
| help: add the required where clause: `where T: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Out`
--> $DIR/self-outlives-lint.rs:39:5
@ -28,8 +28,8 @@ LL | type Out<'x>;
| |
| help: add the required where clause: `where T: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bounds on `Out`
--> $DIR/self-outlives-lint.rs:46:5
@ -39,8 +39,8 @@ LL | type Out<'x, 'y>;
| |
| help: add the required where clauses: `where T: 'x, U: 'y`
|
= note: these bounds are required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: these bounds are currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Out`
--> $DIR/self-outlives-lint.rs:61:5
@ -50,8 +50,8 @@ LL | type Out<'x, D>;
| |
| help: add the required where clause: `where D: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Out`
--> $DIR/self-outlives-lint.rs:77:5
@ -61,8 +61,8 @@ LL | type Out<'x, D>;
| |
| help: add the required where clause: `where D: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Out`
--> $DIR/self-outlives-lint.rs:92:5
@ -72,8 +72,8 @@ LL | type Out<'x, D>;
| |
| help: add the required where clause: `where D: 'x`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bounds on `Bar`
--> $DIR/self-outlives-lint.rs:114:5
@ -83,8 +83,8 @@ LL | type Bar<'b>;
| |
| help: add the required where clauses: `where Self: 'a, Self: 'b`
|
= note: these bounds are required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: these bounds are currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Bar`
--> $DIR/self-outlives-lint.rs:122:5
@ -94,8 +94,8 @@ LL | type Bar<'b>;
| |
| help: add the required where clause: `where Self: 'b`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Bar`
--> $DIR/self-outlives-lint.rs:129:5
@ -105,8 +105,8 @@ LL | type Bar<'b>;
| |
| help: add the required where clause: `where Self: 'b`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Iterator`
--> $DIR/self-outlives-lint.rs:143:5
@ -116,8 +116,8 @@ LL | type Iterator<'a>: Iterator<Item = Self::Item<'a>>;
| |
| help: add the required where clause: `where Self: 'a`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Bar`
--> $DIR/self-outlives-lint.rs:151:5
@ -127,8 +127,8 @@ LL | type Bar<'a, 'b>;
| |
| help: add the required where clause: `where 'b: 'a`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: missing required bound on `Fut`
--> $DIR/self-outlives-lint.rs:167:5
@ -138,8 +138,8 @@ LL | type Fut<'out>;
| |
| help: add the required where clause: `where 'ctx: 'out`
|
= note: this bound is required to ensure that impls have maximum flexibility
= note: see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
= note: this bound is currently required to ensure that impls have maximum flexibility
= note: we are soliciting feedback, see issue #87479 <https://github.com/rust-lang/rust/issues/87479> for more information
error: aborting due to 13 previous errors