bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #61545 - flip1995:internal_lints, r=oli-obk

Browse source 
Implement another internal lints

cc #49509

This adds ~~two~~ one internal lint~~s~~:
1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc #59669
2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in #49509~~

~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~

TODO (not directly relevant for review):
- [ ] https://github.com/rust-lang/rust/pull/59316#discussion_r280186517 (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb)
- [x] https://github.com/rust-lang/rust/pull/61735#discussion_r292389870
- [x] Check explicitly for the `{declare,impl}_lint_pass!` macros

r? @oli-obk
This commit is contained in:
Mazdak Farrokhzad 2019-07-05 20:26:51 +02:00 • committed by GitHub
commit 485a084b45
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
49 changed files with 209 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/librustc_errors/lib.rs
View file

@ -10,7 +10,6 @@
#![feature(nll)]
#![feature(optin_builtin_traits)]
#![deny(rust_2018_idioms)]
#![deny(internal)]
#![deny(unused_lifetimes)]
#[allow(unused_extern_crates)]