bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #97697 - WaffleLapkin:no_ref_vec, r=WaffleLapkin

Browse source 
Replace `&Vec<_>`s with `&[_]`s

It's generally preferable to use `&[_]` since it's one less indirection and it can be created from types other that `Vec`.

I've left `&Vec` in some locals where it doesn't really matter, in cases where `TypeFoldable` is expected (`TypeFoldable: Clone` so slice can't implement it) and in cases where it's `&TypeAliasThatIsActiallyVec`. Nothing important, really, I was just a little annoyed by `visit_generic_param_vec` :D

r? `@compiler-errors`
This commit is contained in:
bors 2022-06-05 09:30:53 +00:00
commit 4322a785cc
14 changed files with 53 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_errors/src/diagnostic.rs
View file

@ -827,7 +827,7 @@ impl Diagnostic {
self
}
pub fn styled_message(&self) -> &Vec<(DiagnosticMessage, Style)> {
pub fn styled_message(&self) -> &[(DiagnosticMessage, Style)] {
&self.message
}
@ -888,11 +888,11 @@ impl Diagnostic {
&self,
) -> (
&Level,
&Vec<(DiagnosticMessage, Style)>,
&[(DiagnosticMessage, Style)],
&Option<DiagnosticId>,
&MultiSpan,
&Result<Vec<CodeSuggestion>, SuggestionsDisabled>,
Option<&Vec<SubDiagnostic>>,
Option<&[SubDiagnostic]>,
) {
(
&self.level,