unused_unsafe: don't label irrelevant fns
This commit is contained in:
parent
5313e8728f
commit
42df8c56cc
2 changed files with 44 additions and 2 deletions
|
@ -386,10 +386,13 @@ fn is_enclosed(tcx: TyCtxt,
|
|||
if used_unsafe.contains(&parent_id) {
|
||||
Some(("block".to_string(), parent_id))
|
||||
} else if let Some(hir::map::NodeItem(&hir::Item {
|
||||
node: hir::ItemFn(_, hir::Unsafety::Unsafe, _, _, _, _),
|
||||
node: hir::ItemFn(_, fn_unsafety, _, _, _, _),
|
||||
..
|
||||
})) = tcx.hir.find(parent_id) {
|
||||
Some(("fn".to_string(), parent_id))
|
||||
match fn_unsafety {
|
||||
hir::Unsafety::Unsafe => Some(("fn".to_string(), parent_id)),
|
||||
hir::Unsafety::Normal => None,
|
||||
}
|
||||
} else {
|
||||
is_enclosed(tcx, used_unsafe, parent_id)
|
||||
}
|
||||
|
|
39
src/test/compile-fail/issue-48131.rs
Normal file
39
src/test/compile-fail/issue-48131.rs
Normal file
|
@ -0,0 +1,39 @@
|
|||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
// This note is annotated because the purpose of the test
|
||||
// is to ensure that certain other notes are not generated.
|
||||
#![deny(unused_unsafe)] //~ NOTE
|
||||
|
||||
// (test that no note is generated on this unsafe fn)
|
||||
pub unsafe fn a() {
|
||||
fn inner() {
|
||||
unsafe { /* unnecessary */ } //~ ERROR unnecessary `unsafe`
|
||||
//~^ NOTE
|
||||
}
|
||||
|
||||
inner()
|
||||
}
|
||||
|
||||
pub fn b() {
|
||||
// (test that no note is generated on this unsafe block)
|
||||
unsafe {
|
||||
fn inner() {
|
||||
unsafe { /* unnecessary */ } //~ ERROR unnecessary `unsafe`
|
||||
//~^ NOTE
|
||||
}
|
||||
|
||||
let () = ::std::mem::uninitialized();
|
||||
|
||||
inner()
|
||||
}
|
||||
}
|
||||
|
||||
fn main() {}
|
Loading…
Add table
Add a link
Reference in a new issue