bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Use aapcs for efiapi calling convention on arm

Browse source 
On arm, llvm treats the C calling convention as `aapcs` on soft-float
targets and `aapcs-vfp` on hard-float targets [1]. UEFI specifies in the
arm calling convention that floating point extensions aren't used [2],
so always translate `efiapi` to `aapcs` on arm.

[1]: https://github.com/rust-lang/compiler-builtins/issues/116#issuecomment-261057422
[2]: https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention

https://github.com/rust-lang/rust/issues/65815
This commit is contained in:
Nicholas Bishop 2022-11-06 17:29:46 -05:00
parent 7eef946fc0
commit 42cbb40157
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
compiler/rustc_target/src/spec/mod.rs
View file

@ -1915,6 +1915,7 @@ impl Target {
Abi::Stdcall { unwind } Abi::Stdcall { unwind }
} }
Abi::System { unwind } => Abi::C { unwind }, Abi::System { unwind } => Abi::C { unwind },
Abi::EfiApi if self.arch == "arm" => Abi::Aapcs { unwind: false },
Abi::EfiApi if self.arch == "x86_64" => Abi::Win64 { unwind: false }, Abi::EfiApi if self.arch == "x86_64" => Abi::Win64 { unwind: false },
Abi::EfiApi => Abi::C { unwind: false }, Abi::EfiApi => Abi::C { unwind: false },

2
src/test/codegen/abi-efiapi.rs
View file

@ -27,7 +27,7 @@ trait Copy { }
//x86_64: define win64cc void @has_efiapi //x86_64: define win64cc void @has_efiapi
//i686: define void @has_efiapi //i686: define void @has_efiapi
//aarch64: define dso_local void @has_efiapi //aarch64: define dso_local void @has_efiapi
//arm: define dso_local void @has_efiapi //arm: define dso_local arm_aapcscc void @has_efiapi
//riscv: define dso_local void @has_efiapi //riscv: define dso_local void @has_efiapi
#[no_mangle] #[no_mangle]
pub extern "efiapi" fn has_efiapi() {} pub extern "efiapi" fn has_efiapi() {}