bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

EvalCtxt::commit_if_ok don't inherit nested goals

Browse source
This commit is contained in:
lcnr 2023-11-24 15:20:02 +01:00
parent 7bd385dc37
commit 42a9b0d7ab
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_trait_selection/src/solve/mod.rs
View file

@ -334,11 +334,6 @@ impl<'tcx> EvalCtxt<'_, 'tcx> {
}
}
// FIXME(@lcnr): If the normalization of the alias adds an inference constraint which
// causes a previously added goal to fail, then we treat the alias as rigid.
//
// These feels like a potential issue, I should look into writing some tests here
// and then probably changing `commit_if_ok` to not inherit the parent goals.
match self.commit_if_ok(|this| {
let normalized_ty = this.next_ty_infer();
let normalizes_to_goal = Goal::new(