bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Rollup merge of #80509 - matthiaskrgr:ptr_arg, r=varkor

Browse source 
where possible, pass slices instead of &Vec or &String (clippy::ptr_arg)
This commit is contained in:
Yuki Okushi 2020-12-30 22:49:26 +09:00 • committed by GitHub
commit 41fa0dba27
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 21 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_macros/src/session_diagnostic.rs
View file

@ -574,7 +574,7 @@ impl<'a> SessionDiagnosticDeriveBuilder<'a> {
/// format!("Expected a point greater than ({x}, {y})", x = self.x, y = self.y)
/// ```
/// This function builds the entire call to format!.
fn build_format(&self, input: &String, span: proc_macro2::Span) -> proc_macro2::TokenStream {
fn build_format(&self, input: &str, span: proc_macro2::Span) -> proc_macro2::TokenStream {
// This set is used later to generate the final format string. To keep builds reproducible,
// the iteration order needs to be deterministic, hence why we use a BTreeSet here instead
// of a HashSet.