Make Decodable
and Decoder
infallible.
`Decoder` has two impls: - opaque: this impl is already partly infallible, i.e. in some places it currently panics on failure (e.g. if the input is too short, or on a bad `Result` discriminant), and in some places it returns an error (e.g. on a bad `Option` discriminant). The number of places where either happens is surprisingly small, just because the binary representation has very little redundancy and a lot of input reading can occur even on malformed data. - json: this impl is fully fallible, but it's only used (a) for the `.rlink` file production, and there's a `FIXME` comment suggesting it should change to a binary format, and (b) in a few tests in non-fundamental ways. Indeed #85993 is open to remove it entirely. And the top-level places in the compiler that call into decoding just abort on error anyway. So the fallibility is providing little value, and getting rid of it leads to some non-trivial performance improvements. Much of this commit is pretty boring and mechanical. Some notes about a few interesting parts: - The commit removes `Decoder::{Error,error}`. - `InternIteratorElement::intern_with`: the impl for `T` now has the same optimization for small counts that the impl for `Result<T, E>` has, because it's now much hotter. - Decodable impls for SmallVec, LinkedList, VecDeque now all use `collect`, which is nice; the one for `Vec` uses unsafe code, because that gave better perf on some benchmarks.
This commit is contained in:
parent
88600a6d7f
commit
416399dc10
39 changed files with 726 additions and 781 deletions
|
@ -619,20 +619,20 @@ impl<'tcx, E: TyEncoder<'tcx>, T: Encodable<E>> Encodable<E> for ClearCrossCrate
|
|||
}
|
||||
impl<'tcx, D: TyDecoder<'tcx>, T: Decodable<D>> Decodable<D> for ClearCrossCrate<T> {
|
||||
#[inline]
|
||||
fn decode(d: &mut D) -> Result<ClearCrossCrate<T>, D::Error> {
|
||||
fn decode(d: &mut D) -> ClearCrossCrate<T> {
|
||||
if D::CLEAR_CROSS_CRATE {
|
||||
return Ok(ClearCrossCrate::Clear);
|
||||
return ClearCrossCrate::Clear;
|
||||
}
|
||||
|
||||
let discr = u8::decode(d)?;
|
||||
let discr = u8::decode(d);
|
||||
|
||||
match discr {
|
||||
TAG_CLEAR_CROSS_CRATE_CLEAR => Ok(ClearCrossCrate::Clear),
|
||||
TAG_CLEAR_CROSS_CRATE_CLEAR => ClearCrossCrate::Clear,
|
||||
TAG_CLEAR_CROSS_CRATE_SET => {
|
||||
let val = T::decode(d)?;
|
||||
Ok(ClearCrossCrate::Set(val))
|
||||
let val = T::decode(d);
|
||||
ClearCrossCrate::Set(val)
|
||||
}
|
||||
tag => Err(d.error(&format!("Invalid tag for ClearCrossCrate: {:?}", tag))),
|
||||
tag => panic!("Invalid tag for ClearCrossCrate: {:?}", tag),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue