bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

add note about indirect cycles

Browse source
This commit is contained in:
lcnr 2023-01-17 16:00:00 +01:00
parent 31ac29d989
commit 415aa663a2
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_trait_selection/src/solve/search_graph/cache.rs
View file

@ -59,6 +59,10 @@ impl<'tcx> ProvisionalCache<'tcx> {
/// Adds a dependency from the current leaf to `target` in the cache
/// to prevent us from moving any goals which depend on the current leaf
/// to the global cache while we're still computing `target`.
///
/// Its important to note that `target` may already be part of a different cycle.
/// In this case we have to ensure that we also depend on all other goals
/// in the existing cycle in addition to the potentially direct cycle with `target`.
pub(super) fn add_dependency_of_leaf_on(&mut self, target: EntryIndex) {
let depth = self.entries[target].depth;
for provisional_entry in &mut self.entries.raw[target.index()..] {