bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

use partition_point instead of binary_search when looking up source lines

Browse source 
In local benchmarks this results in 0.4% fewer cycles in a critical sequential
section when compiling libcore.
This commit is contained in:
The 8472 2022-09-19 00:25:44 +02:00
parent 98ad6a5519
commit 40b37268eb
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_span/src/lib.rs
View file

@ -1631,10 +1631,9 @@ impl SourceFile {
/// number. If the source_file is empty or the position is located before the /// number. If the source_file is empty or the position is located before the
/// first line, `None` is returned. /// first line, `None` is returned.
pub fn lookup_line(&self, pos: BytePos) -> Option<usize> { pub fn lookup_line(&self, pos: BytePos) -> Option<usize> {
self.lines(|lines| match lines.binary_search(&pos) { self.lines(|lines| match lines.partition_point(|x| x <= &pos) {
Ok(idx) => Some(idx), 0 => None,
Err(0) => None, i => Some(i - 1),
Err(idx) => Some(idx - 1),
}) })
} }