bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

refactor function

Browse source
This commit is contained in:
gnzlbg 2018-07-05 01:53:40 +02:00
parent 14cbdf2607
commit 3fec3b47b6
1 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
clippy_lints/src/missing_inline.rs
View file

@ -67,19 +67,17 @@ declare_clippy_lint! {
pub struct MissingInline; pub struct MissingInline;
impl MissingInline { fn check_missing_inline_attrs(cx: &LateContext,
fn check_missing_inline_attrs(&self, cx: &LateContext, attrs: &[ast::Attribute], sp: Span, desc: &'static str) {
attrs: &[ast::Attribute], sp: Span, desc: &'static str) { let has_inline = attrs
let has_inline = attrs .iter()
.iter() .any(|a| a.name() == "inline" );
.any(|a| a.name() == "inline" ); if !has_inline {
if !has_inline { cx.span_lint(
cx.span_lint( MISSING_INLINE_IN_PUBLIC_ITEMS,
MISSING_INLINE_IN_PUBLIC_ITEMS, sp,
sp, &format!("missing `#[inline]` for {}", desc),
&format!("missing `#[inline]` for {}", desc), );
);
}
} }
} }
@ -112,7 +110,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
match it.node { match it.node {
hir::ItemFn(..) => { hir::ItemFn(..) => {
let desc = "a function"; let desc = "a function";
self.check_missing_inline_attrs(cx, &it.attrs, it.span, desc); check_missing_inline_attrs(cx, &it.attrs, it.span, desc);
}, },
hir::ItemTrait(ref _is_auto, ref _unsafe, ref _generics, hir::ItemTrait(ref _is_auto, ref _unsafe, ref _generics,
ref _bounds, ref trait_items) => { ref _bounds, ref trait_items) => {
@ -129,7 +127,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
// an impl is not provided // an impl is not provided
let desc = "a default trait method"; let desc = "a default trait method";
let item = cx.tcx.hir.expect_trait_item(tit.id.node_id); let item = cx.tcx.hir.expect_trait_item(tit.id.node_id);
self.check_missing_inline_attrs(cx, &item.attrs, check_missing_inline_attrs(cx, &item.attrs,
item.span, desc); item.span, desc);
} }
}, },
@ -195,6 +193,6 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingInline {
}, },
} }
self.check_missing_inline_attrs(cx, &impl_item.attrs, impl_item.span, desc); check_missing_inline_attrs(cx, &impl_item.attrs, impl_item.span, desc);
} }
} }