Merge pull request #354 from Pyriphlegethon/master
Add "unnecessary mut passed" lint
This commit is contained in:
commit
3e475e9588
5 changed files with 126 additions and 2 deletions
|
@ -33,6 +33,7 @@ pub mod eta_reduction;
|
|||
pub mod identity_op;
|
||||
pub mod minmax;
|
||||
pub mod mut_mut;
|
||||
pub mod mut_reference;
|
||||
pub mod len_zero;
|
||||
pub mod attrs;
|
||||
pub mod collapsible_if;
|
||||
|
@ -66,6 +67,7 @@ pub fn plugin_registrar(reg: &mut Registry) {
|
|||
reg.register_late_lint_pass(box eta_reduction::EtaPass);
|
||||
reg.register_late_lint_pass(box identity_op::IdentityOp);
|
||||
reg.register_late_lint_pass(box mut_mut::MutMut);
|
||||
reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
|
||||
reg.register_late_lint_pass(box len_zero::LenZero);
|
||||
reg.register_late_lint_pass(box misc::CmpOwned);
|
||||
reg.register_late_lint_pass(box attrs::AttrPass);
|
||||
|
@ -138,6 +140,7 @@ pub fn plugin_registrar(reg: &mut Registry) {
|
|||
misc::MODULO_ONE,
|
||||
misc::REDUNDANT_PATTERN,
|
||||
misc::TOPLEVEL_REF_ARG,
|
||||
mut_reference::UNNECESSARY_MUT_PASSED,
|
||||
needless_bool::NEEDLESS_BOOL,
|
||||
precedence::PRECEDENCE,
|
||||
ranges::RANGE_STEP_BY_ZERO,
|
||||
|
|
74
src/mut_reference.rs
Normal file
74
src/mut_reference.rs
Normal file
|
@ -0,0 +1,74 @@
|
|||
use rustc::lint::*;
|
||||
use rustc_front::hir::*;
|
||||
use utils::span_lint;
|
||||
use rustc::middle::ty::{TypeAndMut, TypeVariants, MethodCall, TyS};
|
||||
use syntax::ptr::P;
|
||||
|
||||
declare_lint! {
|
||||
pub UNNECESSARY_MUT_PASSED,
|
||||
Warn,
|
||||
"an argument is passed as a mutable reference although the function/method only demands an \
|
||||
immutable reference"
|
||||
}
|
||||
|
||||
|
||||
#[derive(Copy,Clone)]
|
||||
pub struct UnnecessaryMutPassed;
|
||||
|
||||
impl LintPass for UnnecessaryMutPassed {
|
||||
fn get_lints(&self) -> LintArray {
|
||||
lint_array!(UNNECESSARY_MUT_PASSED)
|
||||
}
|
||||
}
|
||||
|
||||
impl LateLintPass for UnnecessaryMutPassed {
|
||||
fn check_expr(&mut self, cx: &LateContext, e: &Expr) {
|
||||
let borrowed_table = cx.tcx.tables.borrow();
|
||||
match e.node {
|
||||
ExprCall(ref fn_expr, ref arguments) => {
|
||||
match borrowed_table.node_types.get(&fn_expr.id) {
|
||||
Some(function_type) => {
|
||||
if let ExprPath(_, ref path) = fn_expr.node {
|
||||
check_arguments(cx, &arguments, function_type,
|
||||
&format!("{}", path));
|
||||
}
|
||||
},
|
||||
None => unreachable!(), // A function with unknown type is called.
|
||||
// If this happened the compiler would have aborted the
|
||||
// compilation long ago.
|
||||
};
|
||||
|
||||
|
||||
},
|
||||
ExprMethodCall(ref name, _, ref arguments) => {
|
||||
let method_call = MethodCall::expr(e.id);
|
||||
match borrowed_table.method_map.get(&method_call) {
|
||||
Some(method_type) => check_arguments(cx, &arguments, method_type.ty,
|
||||
&format!("{}", name.node.as_str())),
|
||||
None => unreachable!(), // Just like above, this should never happen.
|
||||
};
|
||||
},
|
||||
_ => {}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn check_arguments(cx: &LateContext, arguments: &[P<Expr>], type_definition: &TyS, name: &str) {
|
||||
if let TypeVariants::TyBareFn(_, ref fn_type) = type_definition.sty {
|
||||
let parameters = &fn_type.sig.skip_binder().inputs;
|
||||
for (argument, parameter) in arguments.iter().zip(parameters.iter()) {
|
||||
match parameter.sty {
|
||||
TypeVariants::TyRef(_, TypeAndMut {ty: _, mutbl: MutImmutable}) |
|
||||
TypeVariants::TyRawPtr(TypeAndMut {ty: _, mutbl: MutImmutable}) => {
|
||||
if let Expr_::ExprAddrOf(MutMutable, _) = argument.node {
|
||||
span_lint(cx, UNNECESSARY_MUT_PASSED,
|
||||
argument.span, &format!("The function/method \"{}\" \
|
||||
doesn't need a mutable reference",
|
||||
name));
|
||||
}
|
||||
},
|
||||
_ => {}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue