bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #79073 - davidtwco:issue-78957-const-param-attrs, r=lcnr

Browse source 
passes: prohibit invalid attrs on generic params

Fixes #78957.

This PR modifies the `check_attr` pass so that attribute placement on generic parameters is checked for validity.

r? `@lcnr`
This commit is contained in:
bors 2020-12-19 04:32:50 +00:00
commit 3d9ada686f
6 changed files with 147 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_passes/src/check_attr.rs
View file

@ -882,6 +882,18 @@ impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {
intravisit::walk_item(self, item)
}
fn visit_generic_param(&mut self, generic_param: &'tcx hir::GenericParam<'tcx>) {
let target = Target::from_generic_param(generic_param);
self.check_attributes(
generic_param.hir_id,
generic_param.attrs,
&generic_param.span,
target,
None,
);
intravisit::walk_generic_param(self, generic_param)
}
fn visit_trait_item(&mut self, trait_item: &'tcx TraitItem<'tcx>) {
let target = Target::from_trait_item(trait_item);
self.check_attributes(trait_item.hir_id, &trait_item.attrs, &trait_item.span, target, None);