bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

sugg: take into count the debug formatting

Browse source 
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This commit is contained in:
Vincenzo Palazzo 2022-08-20 23:29:38 +00:00
parent dd01122b5c
commit 3d8c7d2c0a
3 changed files with 38 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_lint/src/context.rs
View file

@ -865,9 +865,14 @@ pub trait LintContext: Sized {
if let Some(positional_arg_to_replace) = position_sp_to_replace {
let name = if is_formatting_arg { named_arg_name + "$" } else { named_arg_name };
let span_to_replace = if let Ok(positional_arg_content) =
self.sess().source_map().span_to_snippet(positional_arg_to_replace) && positional_arg_content.starts_with(":") {
positional_arg_to_replace.shrink_to_lo()
} else {
positional_arg_to_replace
};
db.span_suggestion_verbose(
positional_arg_to_replace,
span_to_replace,
"use the named argument by name to avoid ambiguity",
name,
Applicability::MaybeIncorrect,