bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

report ambiguous type parameters when their parents are impl or fn

Browse source 
fix ci error

emit err for `impl_item`
This commit is contained in:
Takayuki Maeda 2022-05-20 13:49:41 +09:00
parent 910979a6d4
commit 3d0f9fb544
14 changed files with 97 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
View file

@ -941,15 +941,16 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
let mut inner = self.inner.borrow_mut();
let ty_vars = &inner.type_variables();
let var_origin = ty_vars.var_origin(ty_vid);
if let TypeVariableOriginKind::TypeParameterDefinition(name, Some(def_id)) =
if let TypeVariableOriginKind::TypeParameterDefinition(_, Some(def_id)) =
var_origin.kind
&& let Some(parent_def_id) = self.tcx.parent(def_id).as_local()
&& let Some(hir::Node::Item(item)) = self.tcx.hir().find_by_def_id(parent_def_id)
&& let hir::ItemKind::Impl(impl_item) = item.kind
&& let Some(trait_ref) = &impl_item.of_trait
&& let Some(did) = trait_ref.trait_def_id()
&& self.tcx.generics_of(did).params.iter().any(|param| param.name == name)
&& let Some(node) = self.tcx.hir().find_by_def_id(parent_def_id)
{
match node {
hir::Node::Item(item) if matches!(item.kind, hir::ItemKind::Impl(_) | hir::ItemKind::Fn(..)) => (),
hir::Node::ImplItem(impl_item) if matches!(impl_item.kind, hir::ImplItemKind::Fn(..)) => (),
_ => return,
}
err.span_help(self.tcx.def_span(def_id), "type parameter declared here");
}
}