bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

untranslatable_diagnostic lint: point at the untranslated thing

Browse source 
and not the function/method call
This commit is contained in:
Pavel Grigorenko 2024-08-10 19:29:20 +03:00
parent 10ef6661bc
commit 3cc2a6fdcb
2 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

22
compiler/rustc_lint/src/internal.rs
View file

@ -415,14 +415,17 @@ declare_lint_pass!(Diagnostics => [UNTRANSLATABLE_DIAGNOSTIC, DIAGNOSTIC_OUTSIDE
impl LateLintPass<'_> for Diagnostics { impl LateLintPass<'_> for Diagnostics {
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) { fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
let collect_args_tys_and_spans = |args: &[Expr<'_>], reserve_one_extra: bool| {
let mut result = Vec::with_capacity(args.len() + usize::from(reserve_one_extra));
result.extend(args.iter().map(|arg| (cx.typeck_results().expr_ty(arg), arg.span)));
result
};
// Only check function calls and method calls. // Only check function calls and method calls.
let (span, def_id, fn_gen_args, call_tys) = match expr.kind { let (span, def_id, fn_gen_args, arg_tys_and_spans) = match expr.kind {
ExprKind::Call(callee, args) => { ExprKind::Call(callee, args) => {
match cx.typeck_results().node_type(callee.hir_id).kind() { match cx.typeck_results().node_type(callee.hir_id).kind() {
&ty::FnDef(def_id, fn_gen_args) => { &ty::FnDef(def_id, fn_gen_args) => {
let call_tys: Vec<_> = (callee.span, def_id, fn_gen_args, collect_args_tys_and_spans(args, false))
args.iter().map(|arg| cx.typeck_results().expr_ty(arg)).collect();
(callee.span, def_id, fn_gen_args, call_tys)
} }
_ => return, // occurs for fns passed as args _ => return, // occurs for fns passed as args
} }
@ -432,10 +435,9 @@ impl LateLintPass<'_> for Diagnostics {
else { else {
return; return;
}; };
let mut call_tys: Vec<_> = let mut args = collect_args_tys_and_spans(args, true);
args.iter().map(|arg| cx.typeck_results().expr_ty(arg)).collect(); args.insert(0, (cx.tcx.types.self_param, _recv.span)); // dummy inserted for `self`
call_tys.insert(0, cx.tcx.types.self_param); // dummy inserted for `self` (span, def_id, fn_gen_args, args)
(span, def_id, fn_gen_args, call_tys)
} }
_ => return, _ => return,
}; };
@ -525,11 +527,11 @@ impl LateLintPass<'_> for Diagnostics {
// `UNTRANSLATABLE_DIAGNOSTIC` lint. // `UNTRANSLATABLE_DIAGNOSTIC` lint.
for (param_i, param_i_p_name) in impl_into_diagnostic_message_params { for (param_i, param_i_p_name) in impl_into_diagnostic_message_params {
// Is the arg type `{Sub,D}iagMessage`or `impl Into<{Sub,D}iagMessage>`? // Is the arg type `{Sub,D}iagMessage`or `impl Into<{Sub,D}iagMessage>`?
let arg_ty = call_tys[param_i]; let (arg_ty, arg_span) = arg_tys_and_spans[param_i];
let is_translatable = is_diag_message(arg_ty) let is_translatable = is_diag_message(arg_ty)
|| matches!(arg_ty.kind(), ty::Param(p) if p.name == param_i_p_name); || matches!(arg_ty.kind(), ty::Param(p) if p.name == param_i_p_name);
if !is_translatable { if !is_translatable {
cx.emit_span_lint(UNTRANSLATABLE_DIAGNOSTIC, span, UntranslatableDiag); cx.emit_span_lint(UNTRANSLATABLE_DIAGNOSTIC, arg_span, UntranslatableDiag);
} }
} }
} }

34
tests/ui-fulldeps/internal-lints/diagnostics.stderr
View file

@ -1,8 +1,8 @@
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:43:9 --> $DIR/diagnostics.rs:43:31
| |
LL | Diag::new(dcx, level, "untranslatable diagnostic") LL | Diag::new(dcx, level, "untranslatable diagnostic")
| ^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
note: the lint level is defined here note: the lint level is defined here
--> $DIR/diagnostics.rs:7:9 --> $DIR/diagnostics.rs:7:9
@ -11,16 +11,16 @@ LL | #![deny(rustc::untranslatable_diagnostic)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:64:14 --> $DIR/diagnostics.rs:64:19
| |
LL | diag.note("untranslatable diagnostic"); LL | diag.note("untranslatable diagnostic");
| ^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:85:14 --> $DIR/diagnostics.rs:85:19
| |
LL | diag.note("untranslatable diagnostic"); LL | diag.note("untranslatable diagnostic");
| ^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should only be created in `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls error: diagnostics should only be created in `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls
--> $DIR/diagnostics.rs:99:21 --> $DIR/diagnostics.rs:99:21
@ -41,36 +41,34 @@ LL | let _diag = dcx.struct_err("untranslatable diagnostic");
| ^^^^^^^^^^ | ^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:102:21 --> $DIR/diagnostics.rs:102:32
| |
LL | let _diag = dcx.struct_err("untranslatable diagnostic"); LL | let _diag = dcx.struct_err("untranslatable diagnostic");
| ^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:120:5 --> $DIR/diagnostics.rs:120:7
| |
LL | f("untranslatable diagnostic", crate::fluent_generated::no_crate_example); LL | f("untranslatable diagnostic", crate::fluent_generated::no_crate_example);
| ^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:122:5 --> $DIR/diagnostics.rs:122:50
| |
LL | f(crate::fluent_generated::no_crate_example, "untranslatable diagnostic"); LL | f(crate::fluent_generated::no_crate_example, "untranslatable diagnostic");
| ^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:124:5 --> $DIR/diagnostics.rs:124:7
| |
LL | f("untranslatable diagnostic", "untranslatable diagnostic"); LL | f("untranslatable diagnostic", "untranslatable diagnostic");
| ^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages error: diagnostics should be created using translatable messages
--> $DIR/diagnostics.rs:124:5 --> $DIR/diagnostics.rs:124:36
| |
LL | f("untranslatable diagnostic", "untranslatable diagnostic"); LL | f("untranslatable diagnostic", "untranslatable diagnostic");
| ^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
error: aborting due to 10 previous errors error: aborting due to 10 previous errors