bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Auto merge of #114266 - calebzulawski:simd-bswap, r=compiler-errors

Browse source 
Fix simd_bswap for i8/u8

#114156 missed this test case ☹️
cc `@workingjubilee`
This commit is contained in:
bors 2023-07-31 04:43:48 +00:00
commit 3be07c1161
2 changed files with 32 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/rustc_codegen_llvm/src/intrinsic.rs
View file

@ -2096,29 +2096,28 @@ fn generic_simd_intrinsic<'ll, 'tcx>(
sym::simd_cttz => "cttz",
_ => unreachable!(),
};
let llvm_intrinsic = &format!(
"llvm.{}.v{}i{}",
intrinsic_name,
in_len,
in_elem.int_size_and_signed(bx.tcx()).0.bits(),
);
let int_size = in_elem.int_size_and_signed(bx.tcx()).0.bits();
let llvm_intrinsic = &format!("llvm.{}.v{}i{}", intrinsic_name, in_len, int_size,);
return Ok(if matches!(name, sym::simd_ctlz | sym::simd_cttz) {
return if name == sym::simd_bswap && int_size == 8 {
// byte swap is no-op for i8/u8
Ok(args[0].immediate())
} else if matches!(name, sym::simd_ctlz | sym::simd_cttz) {
let fn_ty = bx.type_func(&[vec_ty, bx.type_i1()], vec_ty);
let f = bx.declare_cfn(llvm_intrinsic, llvm::UnnamedAddr::No, fn_ty);
bx.call(
Ok(bx.call(
fn_ty,
None,
None,
f,
&[args[0].immediate(), bx.const_int(bx.type_i1(), 0)],
None,
)
))
} else {
let fn_ty = bx.type_func(&[vec_ty], vec_ty);
let f = bx.declare_cfn(llvm_intrinsic, llvm::UnnamedAddr::No, fn_ty);
bx.call(fn_ty, None, None, f, &[args[0].immediate()], None)
});
Ok(bx.call(fn_ty, None, None, f, &[args[0].immediate()], None))
};
}
if name == sym::simd_arith_offset {