bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fixed false positive for unused_parens lint

Browse source
This commit is contained in:
aticu 2020-10-14 01:13:48 +02:00
parent adef9da30f
commit 39867f3c9f
4 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
compiler/rustc_lint/src/unused.rs
View file

@ -751,13 +751,20 @@ impl UnusedDelimLint for UnusedParens {
if !Self::is_expr_delims_necessary(inner, followed_by_block)
&& value.attrs.is_empty()
&& !value.span.from_expansion()
&& (ctx != UnusedDelimsCtx::LetScrutineeExpr
|| match inner.kind {
ast::ExprKind::Binary(
rustc_span::source_map::Spanned { node, .. },
_,
_,
) if node.lazy() => false,
_ => true,
})
{
self.emit_unused_delims_expr(cx, value, ctx, left_pos, right_pos)
}
}
ast::ExprKind::Let(_, ref expr) => {
// FIXME(#60336): Properly handle `let true = (false && true)`
// actually needing the parenthesis.
self.check_unused_delims_expr(
cx,
expr,