Address PR comments
This commit is contained in:
parent
ddaf523aa4
commit
3864d8943b
2 changed files with 6 additions and 2 deletions
|
@ -200,7 +200,7 @@ impl Diagnostic {
|
|||
children: db.children.iter().map(|c| {
|
||||
Diagnostic::from_sub_diagnostic(c, je)
|
||||
}).chain(sugg).collect(),
|
||||
rendered: Some(output.to_owned()),
|
||||
rendered: Some(output),
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -2411,7 +2411,11 @@ actual:\n\
|
|||
let mut normalized = output.replace(&parent_dir_str, "$DIR");
|
||||
|
||||
if json {
|
||||
normalized = normalized.replace("\\n", "\n"); // verbatim newline in json strings
|
||||
// escaped newlines in json strings should be readable
|
||||
// in the stderr files. There's no point int being correct,
|
||||
// since only humans process the stderr files.
|
||||
// Thus we just turn escaped newlines back into newlines.
|
||||
normalized = normalized.replace("\\n", "\n");
|
||||
}
|
||||
|
||||
normalized = normalized.replace("\\\\", "\\") // denormalize for paths on windows
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue