bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Remove some unnecessary parens in assert! conditions

Browse source 
While working on #122661, some of these started triggering our "unnecessary parens" lints due to a change in the `assert!` desugaring. A cursory search identified a few more. Some of these have been carried from before 1.0, were a bulk rename from the previous name of `assert!` left them in that state. I went and removed as many of these unnecessary parens as possible in order to have fewer annoyances in the future if we make the lint smarter.
This commit is contained in:
Esteban Küber 2025-01-23 18:40:41 +00:00
parent 942db6782f
commit 3815ed63ed
31 changed files with 130 additions and 133 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/ui/for-loop-while/break.rs
View file

@ -8,18 +8,18 @@ pub fn main() {
assert_eq!(i, 20);
let xs = [1, 2, 3, 4, 5, 6];
for x in &xs {
if *x == 3 { break; } assert!((*x <= 3));
if *x == 3 { break; } assert!(*x <= 3);
}
i = 0;
while i < 10 { i += 1; if i % 2 == 0 { continue; } assert!((i % 2 != 0)); }
while i < 10 { i += 1; if i % 2 == 0 { continue; } assert!(i % 2 != 0); }
i = 0;
loop {
i += 1; if i % 2 == 0 { continue; } assert!((i % 2 != 0));
i += 1; if i % 2 == 0 { continue; } assert!(i % 2 != 0);
if i >= 10 { break; }
}
let ys = vec![1, 2, 3, 4, 5, 6];
for x in &ys {
if *x % 2 == 0 { continue; }
assert!((*x % 2 != 0));
assert!(*x % 2 != 0);
}
}