bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Also treat impl definition parent as transparent regarding modules

Browse source
This commit is contained in:
Urgau 2024-11-01 12:44:55 +01:00
parent a0d98ff0e5
commit 37db365948
2 changed files with 72 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_lint/src/non_local_def.rs
View file

@ -151,9 +151,15 @@ impl<'tcx> LateLintPass<'tcx> for NonLocalDefinitions {
// };
// };
// ```
//
// It isn't possible to mix a impl in a module with const-anon, but an item can
// be put inside a module and referenced by a impl so we also have to treat the
// item parent as transparent to module and for consistency we have to do the same
// for impl, otherwise the item-def and impl-def won't have the same parent.
let outermost_impl_parent = peel_parent_while(cx.tcx, parent, |tcx, did| {
tcx.def_kind(did) == DefKind::Const
&& tcx.opt_item_name(did) == Some(kw::Underscore)
tcx.def_kind(did) == DefKind::Mod
|| (tcx.def_kind(did) == DefKind::Const
&& tcx.opt_item_name(did) == Some(kw::Underscore))
});
// 2. We check if any of the paths reference a the `impl`-parent.