bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Improve suggestion to rename type starting with underscore to make it more obvious what is actually suggested

Browse source
This commit is contained in:
Guillaume Gomez 2024-02-29 12:06:51 +01:00
parent 632d26aeff
commit 3770cf7abf
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_resolve/src/diagnostics.rs
View file

@ -1571,9 +1571,10 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
{ {
// When the suggested binding change would be from `x` to `_x`, suggest changing the // When the suggested binding change would be from `x` to `_x`, suggest changing the
// original binding definition instead. (#60164) // original binding definition instead. (#60164)
(span, snippet, ", consider changing it") let post = format!(", consider renaming `{}` into `{snippet}`", suggestion.candidate);
(span, snippet, post)
} else { } else {
(span, suggestion.candidate.to_string(), "") (span, suggestion.candidate.to_string(), String::new())
}; };
let msg = match suggestion.target { let msg = match suggestion.target {
SuggestionTarget::SimilarlyNamed => format!( SuggestionTarget::SimilarlyNamed => format!(