bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fix wrapped valid-range handling in ty_find_init_error

Browse source 
Rust's niche handling allows for wrapping valid ranges with end < start;
for instance, a valid range with start=43 and end=41 means a niche of
42. Most places in the compiler handle this correctly, but
ty_find_init_error assumed that `lo > 0` means the type cannot contain a
zero.

Fix it to handle wrapping ranges.

Add a test to cover this case.
This commit is contained in:
Josh Triplett 2022-10-22 15:37:46 +01:00
parent 26c96e3416
commit 36662dfc83
3 changed files with 73 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_lint/src/builtin.rs
View file

@ -2570,7 +2570,10 @@ impl<'tcx> LateLintPass<'tcx> for InvalidValue {
// return `Bound::Excluded`. (And we have tests checking that we
// handle the attribute correctly.)
// We don't add a span since users cannot declare such types anyway.
(Bound::Included(lo), _) if lo > 0 => {
(Bound::Included(lo), Bound::Included(hi)) if 0 < lo && lo < hi => {
return Some((format!("`{}` must be non-null", ty), None));
}
(Bound::Included(lo), Bound::Unbounded) if 0 < lo => {
return Some((format!("`{}` must be non-null", ty), None));
}
(Bound::Included(_), _) | (_, Bound::Included(_))