Port UnknownArchiveKind

compiler/rustc_codegen_llvm/src/back/archive.rs

@@ -14,7 +14,7 @@ use object::read::macho::FatArch;
 use crate::common;
 use crate::errors::{
     ArchiveBuildFailure, DlltoolFailImportLibrary, ErrorCallingDllTool, ErrorCreatingImportLibrary,
-    ErrorWritingDEFFile,
+    ErrorWritingDEFFile, UnknownArchiveKind,
 };
 use crate::llvm::archive_ro::{ArchiveRO, Child};
 use crate::llvm::{self, ArchiveKind, LLVMMachineType, LLVMRustCOFFShortExport};
@@ -312,9 +312,10 @@ impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
 impl<'a> LlvmArchiveBuilder<'a> {
     fn build_with_llvm(&mut self, output: &Path) -> io::Result<bool> {
         let kind = &*self.sess.target.archive_format;
-        let kind = kind.parse::<ArchiveKind>().map_err(|_| kind).unwrap_or_else(|kind| {
+        let kind = kind
-            self.sess.fatal(&format!("Don't know how to build archive of type: {}", kind))
+            .parse::<ArchiveKind>()
-        });
+            .map_err(|_| kind)
+            .unwrap_or_else(|kind| self.sess.emit_fatal(UnknownArchiveKind { kind: kind }));
 
         let mut additions = mem::take(&mut self.additions);
         let mut strings = Vec::new();

compiler/rustc_codegen_llvm/src/errors.rs

@@ -111,3 +111,9 @@ pub(crate) struct DlltoolFailImportLibrary<'a> {
     pub stdout: Cow<'a, str>,
     pub stderr: Cow<'a, str>,
 }
+
+#[derive(SessionDiagnostic)]
+#[diag(codegen_llvm::unknown_archive_kind)]
+pub(crate) struct UnknownArchiveKind<'a> {
+    pub kind: &'a str,
+}

compiler/rustc_error_messages/locales/en-US/codegen_llvm.ftl

@@ -48,3 +48,6 @@ codegen_llvm_error_calling_dlltool =
 
 codegen_llvm_dlltool_fail_import_library =
     Dlltool could not create import library: {$stdout}\n{$stderr}
+
+codegen_llvm_unknown_archive_kind =
+    Don't know how to build archive of type: {$kind}