bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Detect overflow when the literal is negative

Browse source
This commit is contained in:
spore 2025-01-08 19:00:10 +08:00
parent be2369708a
commit 330be17144
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_lint/src/types/literal.rs
View file

@ -204,7 +204,13 @@ fn get_type_suggestion(t: Ty<'_>, val: u128, negative: bool) -> Option<&'static
match t.kind() { match t.kind() {
ty::Uint(ty::UintTy::Usize) | ty::Int(ty::IntTy::Isize) => None, ty::Uint(ty::UintTy::Usize) | ty::Int(ty::IntTy::Isize) => None,
ty::Uint(_) => Some(Integer::fit_unsigned(val).uint_ty_str()), ty::Uint(_) => Some(Integer::fit_unsigned(val).uint_ty_str()),
ty::Int(_) if negative => Some(Integer::fit_signed(-(val as i128)).int_ty_str()), ty::Int(_) if negative => {
if val > i128::MAX as u128 + 1 {
None
} else {
Some(Integer::fit_signed(val.wrapping_neg() as i128).int_ty_str())
}
}
ty::Int(int) => { ty::Int(int) => {
let unsigned = Integer::fit_unsigned(val); let unsigned = Integer::fit_unsigned(val);
Some(if let Ok(signed) = i128::try_from(val).map(Integer::fit_signed) { Some(if let Ok(signed) = i128::try_from(val).map(Integer::fit_signed) {