bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #83391 - hyd-dev:uwtable, r=alexcrichton

Browse source 
Allow not emitting `uwtable` on Android

`uwtable` is marked as required on Android, so it can't be disabled via `-C force-unwind-tables=no`. However, I found that the reason it's marked as required was to resolve a [backtrace issue in Gecko](https://github.com/rust-lang/rust/issues/49867), and I haven't find any other reasons that make it required ([yet](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Unwind.20tables.20are.20strictly.20required.20on.20Windows.20and.20Android)). Therefore, I assume it's safe to turn it off if a (nice) backtrace is not needed, and submit this PR to allow `-C force-unwind-tables=no` when targeting Android.

Note that I haven't tested this change on Android as I don't have an Android environment for testing.
This commit is contained in:
Dylan DPC 2021-03-24 01:52:30 +01:00 • committed by GitHub
commit 30db261023
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_session/src/session.rs
View file

@ -863,7 +863,7 @@ impl Session {
} else if self.target.requires_uwtable {
true
} else {
self.opts.cg.force_unwind_tables.unwrap_or(false)
self.opts.cg.force_unwind_tables.unwrap_or(self.target.default_uwtable)
}
}