bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

suggest adding a derive for #[default] applied to variants

Browse source
This commit is contained in:
Deadbeef 2022-07-07 04:57:01 +00:00
parent 8824d13161
commit 2f0ccdfbba
3 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/rustc_resolve/src/diagnostics.rs
View file

@ -1499,10 +1499,16 @@ impl<'a> Resolver<'a> {
&& let ModuleKind::Def(DefKind::Enum, def_id, _) = parent_scope.module.kind
&& let Some(span) = self.opt_span(def_id)
{
err.span_help(
self.session.source_map().guess_head_span(span),
"consider adding `#[derive(Default)]` to this enum",
);
let source_map = self.session.source_map();
let head_span = source_map.guess_head_span(span);
if let Ok(head) = source_map.span_to_snippet(head_span) {
err.span_suggestion(head_span, "consider adding a derive", format!("#[derive(Default)]\n{head}"), Applicability::MaybeIncorrect);
} else {
err.span_help(
head_span,
"consider adding `#[derive(Default)]` to this enum",
);
}
}
for ns in [Namespace::MacroNS, Namespace::TypeNS, Namespace::ValueNS] {
if let Ok(binding) = self.early_resolve_ident_in_lexical_scope(