bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Don't access pointer element type for nontemporal store

Browse source 
Simply shift the bitcast from the store to the load, so that
we can use the destination type. I'm not sure the bitcast is
really necessary, but keeping it for now.
This commit is contained in:
Nikita Popov 2021-07-06 21:55:03 +02:00
parent 208173f8e9
commit 2ce1addeba
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_codegen_ssa/src/mir/operand.rs
View file

@ -291,11 +291,10 @@ impl<'a, 'tcx, V: CodegenObject> OperandValue<V> {
OperandValue::Ref(r, None, source_align) => { OperandValue::Ref(r, None, source_align) => {
if flags.contains(MemFlags::NONTEMPORAL) { if flags.contains(MemFlags::NONTEMPORAL) {
// HACK(nox): This is inefficient but there is no nontemporal memcpy. // HACK(nox): This is inefficient but there is no nontemporal memcpy.
// FIXME: Don't access pointer element type. let ty = bx.backend_type(dest.layout);
let ty = bx.element_type(bx.val_ty(r)); let ptr = bx.pointercast(r, bx.type_ptr_to(ty));
let val = bx.load(ty, r, source_align); let val = bx.load(ty, ptr, source_align);
let ptr = bx.pointercast(dest.llval, bx.type_ptr_to(ty)); bx.store_with_flags(val, dest.llval, dest.align, flags);
bx.store_with_flags(val, ptr, dest.align, flags);
return; return;
} }
base::memcpy_ty(bx, dest.llval, dest.align, r, source_align, dest.layout, flags) base::memcpy_ty(bx, dest.llval, dest.align, r, source_align, dest.layout, flags)