bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fix suggestion for unnecessary_ref lint

Browse source
This commit is contained in:
Philipp Hansch 2018-12-09 17:25:45 +01:00
parent 3f978afe8d
commit 298aedf2f8
No known key found for this signature in database
GPG key ID: B6FA06A6E0E2665B
4 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
clippy_lints/src/reference.rs
View file

@ -98,7 +98,7 @@ impl LintPass for DerefPass {
impl EarlyLintPass for DerefPass {
fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
if_chain! {
if let ExprKind::Field(ref object, ref field_name) = e.node;
if let ExprKind::Field(ref object, _) = e.node;
if let ExprKind::Paren(ref parened) = object.node;
if let ExprKind::AddrOf(_, ref inner) = parened.node;
then {
@ -109,11 +109,7 @@ impl EarlyLintPass for DerefPass {
object.span,
"Creating a reference that is immediately dereferenced.",
"try this",
format!(
"{}.{}",
snippet_with_applicability(cx, inner.span, "_", &mut applicability),
snippet_with_applicability(cx, field_name.span, "_", &mut applicability)
),
snippet_with_applicability(cx, inner.span, "_", &mut applicability).to_string(),
applicability,
);
}